Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (some) IE11 testing on AppVeyor #3285

Merged
merged 6 commits into from
Nov 26, 2018
Merged

Add (some) IE11 testing on AppVeyor #3285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a37ed66
add karma-ie-launcher to dev deps
etpinard Nov 23, 2018
491fd8a
add --IE11 test-jasmine CLI opt
etpinard Nov 23, 2018
ba5ccfb
handle CI not CIRCLECI env var in karma.conf
etpinard Nov 23, 2018
05b3b7a
add appveyor.yml, test lib_test.js
etpinard Nov 23, 2018
f18f10e
adapt Lib.cleanNumber test for IE11
etpinard Nov 23, 2018
50218de
ok to test Number.MAX_VALUE and Number.MIN_VALUE in IE
etpinard Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
environment:
nodejs_version: "10"

install:
- ps: Install-Product node $env:nodejs_version
# faster than `npm install`
- npm ci

test_script:
- node --version
- npm --version
- npm run test-jasmine -- lib --IE11

build: off
9 changes: 9 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@
"karma-chrome-launcher": "^2.0.0",
"karma-fail-fast-reporter": "^1.0.5",
"karma-firefox-launcher": "^1.0.1",
"karma-ie-launcher": "^1.0.0",
"karma-jasmine": "^1.1.2",
"karma-jasmine-spec-tags": "^1.0.1",
"karma-spec-reporter": "0.0.32",
Expand Down
7 changes: 5 additions & 2 deletions test/jasmine/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@ var path = require('path');
var minimist = require('minimist');
var constants = require('../../tasks/util/constants');

var isCI = !!process.env.CIRCLECI;
var isCI = !!process.env.CI;
var argv = minimist(process.argv.slice(4), {
string: ['bundleTest', 'width', 'height'],
'boolean': ['info', 'nowatch', 'failFast', 'verbose', 'Chrome', 'Firefox'],
'boolean': ['info', 'nowatch', 'failFast', 'verbose', 'Chrome', 'Firefox', 'IE11'],
alias: {
'Chrome': 'chrome',
'Firefox': ['firefox', 'FF'],
'IE11': ['ie11'],
'bundleTest': ['bundletest', 'bundle_test'],
'nowatch': 'no-watch',
'failFast': 'fail-fast'
Expand Down Expand Up @@ -54,6 +55,7 @@ if(argv.info) {
' - `--info`: show this info message',
' - `--Chrome` (alias `--chrome`): run test in (our custom) Chrome browser',
' - `--Firefox` (alias `--FF`, `--firefox`): run test in (our custom) Firefox browser',
' - `--IE11` (alias -- `ie11`)`: run test in IE11 browser',
' - `--nowatch (dflt: `false`, `true` on CI)`: run karma w/o `autoWatch` / multiple run mode',
' - `--failFast` (dflt: `false`): exit karma upon first test failure',
' - `--verbose` (dflt: `false`): show test result using verbose reporter',
Expand Down Expand Up @@ -302,6 +304,7 @@ func.defaultConfig.files.push(testFileGlob);
var browsers = func.defaultConfig.browsers;
if(argv.Chrome) browsers.push('_Chrome');
if(argv.Firefox) browsers.push('_Firefox');
if(argv.IE11) browsers.push('IE');
if(browsers.length === 0) browsers.push('_Chrome');

module.exports = func;
17 changes: 11 additions & 6 deletions test/jasmine/tests/lib_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1558,12 +1558,17 @@ describe('Test lib.js:', function() {

describe('cleanNumber', function() {
it('should return finite numbers untouched', function() {
[
0, 1, 2, 1234.567,
-1, -100, -999.999,
Number.MAX_VALUE, Number.MIN_VALUE, Number.EPSILON,
-Number.MAX_VALUE, -Number.MIN_VALUE, -Number.EPSILON
].forEach(function(v) {
var vals = [
0, 1, 2, 1234.567, -1, -100, -999.999,
Number.MAX_VALUE, Number.MIN_VALUE,
-Number.MAX_VALUE, -Number.MIN_VALUE
];

if(!Lib.isIE()) {
vals.push(Number.EPSILON, -Number.EPSILON);
}

vals.forEach(function(v) {
expect(Lib.cleanNumber(v)).toBe(v);
});
});
Expand Down