Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the quality of surface objects to better follow the data by using LCM or highly composite numbers #3281

Merged
merged 70 commits into from
Dec 18, 2018
Merged

Improving the quality of surface objects to better follow the data by using LCM or highly composite numbers #3281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
d1065b5
increased resolution for gl-surface3d plots
archmoj Nov 22, 2018
7acba04
baseline improvements
archmoj Nov 22, 2018
bc8f75b
increased time outfor gl-surface3d objects
archmoj Nov 22, 2018
e4a676c
minimal fix for issue 2713
archmoj Nov 23, 2018
08b24fd
updated baseline using minimal fix
archmoj Nov 23, 2018
51ca3e3
before more improvements based on compiste numbers
archmoj Nov 23, 2018
b534987
adding getter functions
archmoj Nov 23, 2018
b18959c
now using identical pad function inside gl-surface3d - and YES no nee…
archmoj Nov 23, 2018
9cd9de8
linking new gl-surface3d module
archmoj Nov 23, 2018
fc619b3
function changes
archmoj Nov 23, 2018
13cb09c
improved logic
archmoj Nov 23, 2018
c0cf4d1
using least common multiple between min steps of x and y axes
archmoj Nov 24, 2018
8511400
finding identical best resolution between two axes steps
archmoj Nov 24, 2018
66a85e1
updated surface baselines using new refine logic
archmoj Nov 24, 2018
0c1e2b2
improved logic needed to reduce high-res cases
archmoj Nov 24, 2018
c09b40c
improved logic needed to reduce high-res cases - fixed syntax
archmoj Nov 24, 2018
bd15b4e
improved logic needed to reduce high-res cases - baseline
archmoj Nov 24, 2018
8d89eb3
apply max res when reduction reached lower bound
archmoj Nov 25, 2018
1832abf
using gl-surface3d 1.3.8
archmoj Nov 26, 2018
292d48c
removed unsed input data in ibm mock
archmoj Nov 26, 2018
9bf1495
correct ibm baseline
archmoj Nov 26, 2018
b8e99b8
apply min resolution for uniform grids instead of 128
archmoj Nov 26, 2018
670f15e
fix dstRes
archmoj Nov 26, 2018
97a9368
revert resDst for the case of 2
archmoj Nov 26, 2018
ae88c63
separated LCMs for X and Y
archmoj Nov 26, 2018
ff6c393
fix for issue 2713
archmoj Nov 26, 2018
1f07e9a
updated baselines for issue 2713
archmoj Nov 26, 2018
e0f5de2
fixing issue 2208 as well
archmoj Nov 26, 2018
59a51f5
new baseline with refine disabled to keep high resolution in one dire…
archmoj Nov 26, 2018
174458a
adding more primes and optimized function to return faster
archmoj Nov 27, 2018
bd8caf1
big prepration to solve floating issues
archmoj Nov 27, 2018
f0c7092
reuse get functions
archmoj Nov 27, 2018
fcb5a86
transalte used in colorscale
archmoj Nov 27, 2018
ad1208b
applying offset in spikes
archmoj Nov 27, 2018
ac319ef
better fix for issue 2208 and prepration for issue-0179 and surfaces …
archmoj Nov 27, 2018
69f250e
updated baseline
archmoj Nov 28, 2018
bd966d8
revised fix for issue 2208
archmoj Nov 28, 2018
b7bfd7a
fix worldOffset
archmoj Nov 28, 2018
288e709
apply world coordinate
archmoj Nov 28, 2018
7da5c08
world > object
archmoj Nov 28, 2018
93fb239
using new log
archmoj Nov 29, 2018
6719353
using new gl-surface3d branch
archmoj Nov 29, 2018
5a5c55b
using changes in gl-surface3d branch
archmoj Nov 29, 2018
926e1a0
baselines updated using new gl-surface3d
archmoj Nov 29, 2018
bb51eb7
removed unsed var
archmoj Nov 29, 2018
f73b758
updated surface3d module
archmoj Nov 29, 2018
0271961
fix fragment and contour shaders
archmoj Nov 29, 2018
bd3b9da
turn off refinements
archmoj Nov 29, 2018
144768c
fix for mesh refinement
archmoj Nov 29, 2018
088a2c7
Merge pull request #3299 from plotly/issue-0179
archmoj Nov 30, 2018
7b302d3
fix to revert ribbons
archmoj Nov 30, 2018
601bbcd
fix robbine baseline...
archmoj Nov 30, 2018
b8047c3
using mediump shaders and fixed the typo of the week
archmoj Nov 30, 2018
be99193
fixes for parametric cases e.g. torus
archmoj Dec 6, 2018
999ab09
function syntax
archmoj Dec 6, 2018
7a051c9
baseline changes using new function
archmoj Dec 6, 2018
0305c8d
added new mock with baseline using v.1.42.5
archmoj Dec 6, 2018
f227e2b
baseline using branch
archmoj Dec 6, 2018
8763093
added parametric surface mock and old baseline using release 1.42.5
archmoj Dec 6, 2018
779aeca
slightly better baseline using branch and objectOffset
archmoj Dec 6, 2018
9c65eef
Merge remote-tracking branch 'origin/master' into issue-2713 to use c…
archmoj Dec 6, 2018
109344f
correct baseline using this branch
archmoj Dec 7, 2018
8860759
removed unused midValue attribute
archmoj Dec 7, 2018
4ea04d5
fixing the function to use totalDist
archmoj Dec 7, 2018
4608966
improve mock for prime edge cases
archmoj Dec 7, 2018
392ec3e
correct baselines using surface updates
archmoj Dec 7, 2018
6140b37
removed objectOffset bound modifications from gl3d scene
archmoj Dec 7, 2018
8317455
improved parametric surface mock
archmoj Dec 8, 2018
b50e4a3
correct new surface baselines
archmoj Dec 8, 2018
f948f45
bump gl-surface version to 1.4.0
archmoj Dec 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"gl-select-box": "^1.0.2",
"gl-spikes2d": "^1.0.1",
"gl-streamtube3d": "^1.1.1",
"gl-surface3d": "^1.3.7",
"gl-surface3d": "^1.4.0",
"gl-text": "^1.1.6",
"glslify": "^6.3.1",
"has-hover": "^1.0.1",
Expand All @@ -97,7 +97,6 @@
"ndarray": "^1.0.18",
"ndarray-fill": "^1.0.2",
"ndarray-homography": "^1.0.0",
"ndarray-ops": "^1.2.2",
"point-cluster": "^3.1.4",
"polybooljs": "^1.2.0",
"regl": "^1.3.7",
Expand Down
Loading