Scatterpolargl fixes #3098
Merged
Scatterpolargl fixes #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... when no gl traces are present on graph.
... just use trace._length instead (which is far less confusing).
- and use same TOO_MANY_POINTS axis expansion logic as scattergl - stash style opts and extend them with position opts during plot.
|
Ready for review again. |
src/traces/scattergl/index.js
Outdated
| @@ -129,13 +126,10 @@ function calc(gd, trace) { | |||
|
|
|||
| // stash scene ref | |||
| stash._scene = scene; | |||
| stash.index = scene.count; | |||
| stash.index = scene.count++; | |||
There was a problem hiding this comment.
this of course works... but I can't say I like using ++ mid-assignment
| function calc(container, trace) { | ||
| var layout = container._fullLayout; | ||
| function calc(gd, trace) { | ||
| var fullLayout = gd._fullLayout; |
There was a problem hiding this comment.
ha yeah, that's certainly clearer! 🍰
|
Beautiful! With the slight exception of #3098 (comment) but I won't hold up the 💃 for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3094 and brings
scatterpolarglaxis expansion on-par withscatterpolar.cc @plotly/plotly_js