Fix Plotly.download using graph id as 1st argument #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/snapshot/download.js
Outdated
| @@ -43,19 +45,19 @@ function downloadImage(gd, opts) { | |||
| reject(new Error('Sorry IE does not support downloading from canvas. Try {format:\'svg\'} instead.')); | |||
| } | |||
|
|
|||
| gd._snapshotInProgress = true; | |||
| _gd._snapshotInProgress = true; | |||
There was a problem hiding this comment.
Won't this fail for the plain object case (_gd === undefined)?
There was a problem hiding this comment.
Good eye. This made me realize Plotly.download with figure objects as first argument was also broken. Fixed and 🔒 ed in -> a5af83c
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2930
cc @alexcjohnson