pie color fix & enhancements #2867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix inheritance of explicit colors by later traces - allow inheritance (of explicit colors) by earlier traces too - add `piecolorway` and `extendpiecolors` for more control over pie colors
|
Wow, this seems amazing, thanks Alex! It'll really help make the UX of the editor wayyy better :) |
|
Closing this PR, will recreate it once #2868 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calcInteractionsstep immediately aftercalc. In principle I feel like we could movesetPositionsover tocalcInteractions, but not vice versa becausesetPositionsis tied to cartesian subplot. But I didn't touchsetPositionsin this PR. I also tried putting this code intoPie.plotbut this failed because the colors are needed for the legend, which gets drawn before the data.layout.piecolorwayandlayout.extendpiecolorsfor more control over pie colors (cc @nicolaskruchten @VeraZab)