Fix scattergl select -> dblclick -> pan bug #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... this reduces the occurance of intermittent failure in
the gl2d_click suite on etpinard's laptop
... in case scatter2d is still linked to markerUnselectedOptions
after a double click and a redraw-free relayout call.
|
So the bug isn't manifest in the figure JSON at all, just on screen? The test looks great, but I agree, @dy should review the actual code change. |
correct. |
|
Ping @dy ! Would be nice to include this in 1.39.3 |
|
💃 |
|
Lgtm 💃! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2767
Can't stop won't stop fixing bugs this week.
I'm not 100% this is the best to fix this bug (@dy would you mind reviewing this?), but the new test case should be a good starting point if ever there's a better solution out there.
cc @alexcjohnson