Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump line2d #2340

Merged
merged 4 commits into from
Feb 6, 2018
Merged

Bump line2d #2340

merged 4 commits into from
Feb 6, 2018

Conversation

dy
Copy link
Contributor

@dy dy commented Feb 6, 2018

Fixes #2335

  • add test

{
"x" : [ 15, 20 ],
"y" : [ 23, 23 ],
"type" : "scattergl",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baseline of the year so far 🎉

@etpinard
Copy link
Contributor

etpinard commented Feb 6, 2018

Related commits: gl-vis/regl-line2d@8aecf49 and gl-vis/regl-line2d@4a9e721

@etpinard
Copy link
Contributor

etpinard commented Feb 6, 2018

Good stuff @dfcreative

Would you mind regenerating the package-lock file? Thanks!

@etpinard etpinard added bug something broken status: reviewable labels Feb 6, 2018
@dy
Copy link
Contributor Author

dy commented Feb 6, 2018

@etpinard done :)

@etpinard
Copy link
Contributor

etpinard commented Feb 6, 2018

Nicely done 💃

@dy dy merged commit ef2bff1 into master Feb 6, 2018
@dy dy deleted the bump-line2d branch February 6, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants