Check if not a left-click, then bail out of onStart #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVvx
force-pushed
the
disable-drag-on-rightclick
branch
from
3eed451 to
0a4bb0d
Compare
AlexVvx
force-pushed
the
disable-drag-on-rightclick
branch
from
0a4bb0d to
7e6e899
Compare
AlexVvx
commented
Oct 13, 2017
| var options = { element: this.element, gd: this.gd }; | ||
| dragElement.init(options); | ||
|
|
||
| options.element.onmousedown({button: 2}) |
There was a problem hiding this comment.
Not sure, that it's a best way to emulate right click, however I can't see any other options.
There was a problem hiding this comment.
looks like in mouse_event we have buttons but if we add button the same way it should allow right-click simulation?
added 3 commits
October 16, 2017 11:25
… disable-drag-on-rightclick # Conflicts: # src/components/dragelement/index.js # test/jasmine/tests/dragelement_test.js
|
I wasn't able to find 'Buttons' in ie spec, but it works well in ie9, so I changed everything to 'buttons'. |
| dragElement.init(options); | ||
|
|
||
| mouseEvent('mousedown', this.x, this.y, { buttons: 2 }); | ||
| expect(countCoverSlip()).toEqual(0); |
There was a problem hiding this comment.
Great! Very clear correspondence to the test above. Two last changes I would suggest, then I think this is ready to go:
- 🌴 Can you move
countCoverSlipout one scope so we don't have to repeat it? - Can you continue through
mouseupas in the test below, and verify thathandleClickhas not been called? (that one ironically looks annoying to DRY 🌴 so you can just repeat the pieces you need.)
…at handler won't being called on right click
|
Fantastic @AlexVvx - thanks for the PR and updates! 💃 - we're calling this a bug fix, so it can go in the release we're planning later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #248
This PR adds check in dragElement. On start, if not a left-click, then bail out of onStart. The purpose of this check is to let developers to use their own context menu instead of browser context menu. Without that check there were no possibility to see 'contextmenu' event when click inside plot container.