Axes line w/o ticklabels fix #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for ferreting this out @etpinard In the case where this fallback is needed, |
Good call. Done in d951f6a |
|
💃 🎉 |
etpinard
commented
Jul 25, 2017
| '$(docker inspect --format \'{{.Id}}\' ' + constants.testContainerName + ')', | ||
| 'lxc-attach', | ||
| '-n', containerId, | ||
| '-f', '/var/lib/docker/containers/' + containerId + '/config.lxc', |
There was a problem hiding this comment.
🔈 Big shoutout to hasimo on the CircleCI forums:
https://discuss.circleci.com/t/container-is-not-defined-on-lxc-attach/14684/5
There was a problem hiding this comment.
🥇 🎺 lets get back in business!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1907
which was broken since eb48a9d where on this line
ax.tickfontis assumed to exist - which isn't the case whenshowticklabelsis false.Commit 3c26cbf first adds a mock inspired by https://codepen.io/plotly/pen/qXWmpY and generates a baseline using
v1.28.3(i.e before the regression).Commit fe20694 proposes a fix where a fallback for
tickfont.sizeis added, similar to another fallback inaxes.js. Notice that commit fe20694 did generate a diff for the new mock, but looks like it is only of a few sub-pixels:cc @alexcjohnson