Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapbox reset view back to initial #1883

Merged
merged 3 commits into from
Jul 18, 2017
Merged

Mapbox reset view back to initial #1883

merged 3 commits into from
Jul 18, 2017

Conversation

etpinard
Copy link
Contributor

... via a new mode bar button and double click.

Moreover, this PR adds the generic toggleHover mode bar button to mapbox subplots.

peek 2017-07-14 13-58

This helps mabpox subplots become more on-par with our other older subplot types (see more in #815). I hope you'll ❤️ the changes.

etpinard added 2 commits July 14, 2017 13:54
- resets view back to initial values
- keep track of those initial values on instantiation
- add *toggleHover* button too (that just works)
- which reset view back to initial values
@etpinard etpinard added this to the 1.29.0 milestone Jul 14, 2017
- too slow on CircleCI machines
@etpinard etpinard changed the title Mapbox reset view back to intial Mapbox reset view back to initial Jul 17, 2017
@alexcjohnson
Copy link
Collaborator

nice and clean. 💃

@etpinard etpinard merged commit 5da3791 into master Jul 18, 2017
@etpinard etpinard deleted the mapbox-doubleclick branch July 18, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants