Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆘 this is debatably a breaking change 🆘
In brief, this PR removes a block (see commit 3d67177) which dates back to the first gl2d implementation and recently highlighted in bbac99b (part of the gl2d annotation PR #1301). Back in #1301, I thought that this block was necessary to correctly draw the gl2d axis ticks, but I was wrong. That block was plain wrong from the start. In more technical terms,
ax.setScale()
sets the correctax._length
, no need to override it usingglplot.viewBox
.Removing this block makes the gl2d baselines more on-par with gl2d. To demonstrate, commits d63578b and fbeb5e9 regenerate the
scattergl
baselines as SVGscatter
traces, so comparing (in swipe mode especially) the baselines in commit 32efccd shows little difference between the SVG and gl2d versions. But comparing the new baselines with the old in the combined diff shows some pretty significant differences.So, what do you think? Can this be considered a bug fix? Or, should we wait for v2?
cc @alexcjohnson @dfcreative @monfera @rreusser
TODO