Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for sort + animate #1739

Closed
wants to merge 1 commit into from
Closed

Conversation

rreusser
Copy link
Contributor

This PR adds a failing test for sort + transform that is fixed by #1737. It basically checks the value of calcdata after the transform has started but before it has finished in order to check that the result is as expected.

/cc @alexcjohnson @etpinard

@rreusser rreusser added status: reviewable bug something broken labels May 26, 2017
@rreusser
Copy link
Contributor Author

rreusser commented May 26, 2017

Was trying this instead, but the animation never resolves. I have no idea what to make of that…

Plotly.plot(gd, {
    data: [{
        x: [1, 2, 3], 
        y: [1, 2, 3], 
        mode: 'markers',
        transforms: [{type: 'sort', target: [1, 3, 2]}]
    }], 
    frames: [
        {name: 'frame1', data: [{y: [1, 2, 3]}]},
        {name: 'frame2', data: [{y: [3, 1, 2]}]}
    ]   
}).then(function () {;
    return Plotly.animate(gd, ['frame2'], {frame: {duration: 200, redraw: false}});
}).then(function () {
    expect(gd.calcdata[0][0].y).toEqual(3);
}).catch(fail).then(done);

@alexcjohnson
Copy link
Collaborator

meh, the simplified one worked for me, merged that into #1737 and closing this PR

@alexcjohnson alexcjohnson deleted the failing-transform-test branch May 26, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants