Transition fillcolor #1722
Merged
Transition fillcolor #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreusser
force-pushed
the
fillcolor-animation
branch
from
88516ea to
66a8abf
Compare
|
Test failure is: @etpinard is that to be expected? Is that an intentionally failing and not yet resolved test? |
Nop. Your patch shouldn't brake that test. |
|
@rreusser I just pressed rebuild on CI, it might just be an intermittent failure. |
|
Sounds good! Oh… sort suggested deterministic, but hover suggests maybe a little flaky. Thanks! |
|
@rreusser ok if I change the label to |
|
Yup! I debated. Do the labels have an effect/use, or is it just for record-keeping? |
To make sure |
Conflicts: test/jasmine/tests/scatter_test.js
rreusser
force-pushed
the
fillcolor-animation
branch
from
66a8abf to
96b4e31
Compare
|
@etpinard I've rebased and looks like now passing 👍 |
|
Great news 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #1721 and transitions fillcolor as expected, which currently only updates on an actual redraw.
An example in which it works: http://rickyreusser.com/demos/plotly-unsupported/fillcolor-animation.html
/cc @cpsievert