Mesh3d colorscale settings #1719
Conversation
etpinard
force-pushed
the
mesh3d-colorscale-settings
branch
from
0982ead to
60b4f44
Compare
| @@ -16,6 +16,8 @@ | |||
| [1, "rgb(0, 0, 255)"] | |||
| ], | |||
| "intensity": [0, 0.33, 0.66, 1], | |||
| "cmin": -0.5, | |||
| "cmax": 0.5, | |||
There was a problem hiding this comment.
Weird. That made the axis labels disappear. I might have to revert back those gl-error3d dependencies bump of commit gl-vis/gl-error3d@d756284
There was a problem hiding this comment.
fixed in f55c6f5 via gl-vis/gl-error3d#3
- previously the colorbar scales were wrong (!) as mesh3d used heatmap/colorbar which expected `zmin` and `zmax` as colorbar bounds. These were undefined, leading to colorbar/draw to fill them with (incorrect) default values.
|
All green on CI, ready for review @alexcjohnson |
| .then(function() { | ||
| _assert([true, 0, 3], [true, 0, 3]); | ||
|
|
||
| return Plotly.purge(gd); |
There was a problem hiding this comment.
To destroy the webgl context.
We should perhaps add that Plotly.purge statement in destroyGraphDiv?
There was a problem hiding this comment.
ah interesting... yeah, would be good to put that in destroyGraphDiv - but it's frustrating that deleting gd from the document isn't sufficient to 🔪 the context - I wonder if we can do something to watch for removing gd and purge automatically? If you think that's not a good idea, we should at least make sure this is well documented somewhere prominent.
| coerce('showscale', true); | ||
| } | ||
| else { | ||
| colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'c'}); |
There was a problem hiding this comment.
nice when you can remove code to add features and fix bugs 🎉
|
So I guess previously these colorscale ranges were erroneously taken from the |
Exactly. |
resolves #1710
requires:
vertexIntensityBoundsparam gl-vis/gl-mesh3d#10 set for[email protected][email protected]