-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the skip api method for sliders and udpatemenus #1699
Conversation
Can you add a test that the |
I've added a test to |
To say that more clearly, as long as the string is coerced correctly, the component code is completely agnostic about what the value is, except to the extent that it feeds back into the state via the command observer, which doesn't apply to this case anyway since the command observer is tested to return that it doesn't know anything about the |
Works for me. All looks great! 💃 |
@@ -20,7 +20,7 @@ var stepsAttrs = { | |||
|
|||
method: { | |||
valType: 'enumerated', | |||
values: ['restyle', 'relayout', 'animate', 'update'], | |||
values: ['restyle', 'relayout', 'animate', 'update', 'skip'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little note on 'skip'
in the description would've been nice. We can get to that later though.
This PR implements half of #1695: the
skip
method by allowing it as a method and otherwise living with it but mostly ignoring it./cc @etpinard @alexcjohnson @n-riesco