Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking "Autoscale" in menu-bar also graphically toggles spikemode #4237

Closed
mscotch1 opened this issue Sep 30, 2019 · 1 comment · Fixed by #4241
Closed

Clicking "Autoscale" in menu-bar also graphically toggles spikemode #4237

mscotch1 opened this issue Sep 30, 2019 · 1 comment · Fixed by #4241
Assignees
@etpinard
Labels
bug something broken

Comments

@mscotch1
Copy link

Steps to reproduce:

  1. Open example
  2. Click "Autoscale" menu bar option
  3. Spike mode is now showing as active, but the spikes don't show up on hover. Clicking spike mode button turns the feature "off," and clicking it again turns spike mode on with the spikes actually showing up.
@etpinard
Copy link
Contributor

etpinard commented Sep 30, 2019 •
edited
Loading

Thanks for spotting that!

The "Toggle Spike Lines" button should not turn on when clicking on the "Autoscale" button.

@etpinard etpinard added the bug something broken label Sep 30, 2019
@etpinard etpinard self-assigned this Oct 1, 2019
etpinard added a commit that referenced this issue Oct 1, 2019
@etpinard
fix #4237 - track current _cartesianSpikesEnabled value
f84f7c3 
... during modebar button on-click logic for cartesian axes.

    Previously, we assume that _cartesianSpikesEnabled was always
    on when clicking on the other modebar buttons for cartesian
    axes. This is obviously wrong.
@etpinard etpinard mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modebar toggle spikes fixup plotly/plotly.js
2 participants
@etpinard @mscotch1