Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rangeslider selection display not updating #3957

Closed
mbkupfer opened this issue Jun 12, 2019 · 1 comment · Fixed by #4022
Closed

Rangeslider selection display not updating #3957

mbkupfer opened this issue Jun 12, 2019 · 1 comment · Fixed by #4022
Assignees
@etpinard
Labels
bug something broken

Comments

@mbkupfer
Copy link

@etpinard, I know it has been sometime, but turning back to merge #3806 and the original bug #3795, I noticed that there is another issue with the rangeslider and selections not being in sync. In this case, the issue is regarding the selection in the rangeslider window not updating when the selection in the graph changes.

I've created a reproducible example on codepen here: https://codepen.io/mbkupfer/pen/zVGwoZ

I also demonstrated this bug in a gif to help clarify. Take note how the selected bars will only update in the rangeslider window only when the rangelisder has a click event.

2019-06-12 16-06-40 2019-06-12 16_09_23
@etpinard etpinard added the bug something broken label Jun 13, 2019
@etpinard
Copy link
Contributor

Thanks very much for the report!

@etpinard etpinard self-assigned this Jul 3, 2019
etpinard added a commit that referenced this issue Jul 4, 2019
@etpinard
fix #3957 - call _module.style(onSelect) passing rangePlot <g.trace>
91885b2 
... during selection mousemove. To do so,

- make _module.styleOnSelect handle a 3rd argument
  (in practice, a d3 selection of <g.trace> of the main plot
  OR the range plot)
- similarly for _module.style methods that get called during selections
etpinard added a commit that referenced this issue Jul 4, 2019
@etpinard
fix #3957 - call _module.style(onSelect) passing rangePlot <g.trace>
d2d84d2 
... during selection mousemove. To do so,

- make _module.styleOnSelect handle a 3rd argument
  (in practice, a d3 selection of <g.trace> of the main plot
  OR the range plot)
- similarly for _module.style methods that get called during selections
etpinard added a commit that referenced this issue Jul 4, 2019
@etpinard
fix #3957 - call _module.style(onSelect) passing rangePlot <g.trace>
fd02c9c 
... during selection mousemove. To do so,

- make _module.styleOnSelect handle a 3rd argument
  (in practice, a d3 selection of <g.trace> of the main plot
  OR the range plot)
- similarly for _module.style methods that get called during selections
etpinard added a commit that referenced this issue Jul 5, 2019
@etpinard
fix #3957 - call _module.style(onSelect) passing rangePlot <g.trace>
3e17627 
... during selection mousemove.  To do so,
- make _module.styleOnSelect handle a 3rd argument
  (in practice, a d3 selection of <g.trace> of the main plot
  OR the range plot)
- similarly for _module.style methods that get called during selections
- N.B. has to "fix" one (wrong) finance select assertion
@etpinard etpinard mentioned this issue Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rangeslider style on select fix plotly/plotly.js
2 participants
@mbkupfer @etpinard