fix to continue respecting 14days dtick

plotly · Mar 27, 2020 · 79b6d95 · 79b6d95
1 parent e7ff33d
commit 79b6d95
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/src/constants/numerical.js b/src/constants/numerical.js
@@ -33,6 +33,7 @@ module.exports = {
      */
     ONEAVGYEAR: 31557600000, // 365.25 days
     ONEAVGMONTH: 2629800000, // 1/12 of ONEAVGYEAR
+    ONEWEEK: 604800000,
     ONEDAY: 86400000,
     ONEHOUR: 3600000,
     ONEMIN: 60000,

diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -25,6 +25,7 @@ var cleanTicks = require('./clean_ticks');
 var constants = require('../../constants/numerical');
 var ONEAVGYEAR = constants.ONEAVGYEAR;
 var ONEAVGMONTH = constants.ONEAVGMONTH;
+var ONEWEEK = constants.ONEWEEK;
 var ONEDAY = constants.ONEDAY;
 var ONEHOUR = constants.ONEHOUR;
 var ONEMIN = constants.ONEMIN;
@@ -808,7 +809,7 @@ axes.autoTicks = function(ax, roughDTick) {
         } else if(roughX2 > ONEDAY) {
             if(ax._hasDayOfWeekBreaks) {
                 ax.dtick = roundDTick(roughDTick, ONEDAY, [1, 1.001, 7, 14]);
-                if(ax.dtick !== ONEDAY) ax.dtick = 7 * ONEDAY;
+                if(ax.dtick < ONEWEEK) ax.dtick = ONEWEEK;
             } else {
                 ax.dtick = roundDTick(roughDTick, ONEDAY, roundDays);
             }

diff --git a/test/image/baselines/axes_breaks-weekends_autorange-reversed.png b/test/image/baselines/axes_breaks-weekends_autorange-reversed.png