fix panning on text chart with invalid array values

plotly · Oct 4, 2017 · 6a44a9a · 6a44a9a
1 parent 7f2604a
commit 6a44a9a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/components/drawing/index.js b/src/components/drawing/index.js
@@ -887,6 +887,9 @@ drawing.setTextPointsScale = function(selection, xScale, yScale) {
         var transforms;
         var el = d3.select(this);
         var text = el.select('text');
+
+        if(!text.node()) return;
+
         var x = parseFloat(text.attr('x') || 0);
         var y = parseFloat(text.attr('y') || 0);
 

diff --git a/test/jasmine/tests/drawing_test.js b/test/jasmine/tests/drawing_test.js
@@ -345,6 +345,11 @@ describe('Drawing', function() {
             Drawing.setTextPointsScale(g, 4, 5);
             expect(g.attr('transform')).toEqual('translate(8,9) scale(4,5) translate(-8,-9) translate(1, 2)');
         });
+
+        it('should not break when <text> is not present', function() {
+            text.remove();
+            expect(function() { Drawing.setTextPointsScale(g, 4, 5); }).not.toThrow();
+        });
     });
 
     describe('bBox', function() {