address issue 5289 - use if block instead of loop

plotly · Nov 19, 2020 · 0a21710 · 0a21710
1 parent 52b5051
commit 0a21710
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/traces/histogram/cross_trace_defaults.js b/src/traces/histogram/cross_trace_defaults.js
@@ -174,10 +174,9 @@ module.exports = function crossTraceDefaults(fullData, fullLayout) {
         }
 
         var binGroupFound = false;
-        for(i = 0; i < traces.length; i++) {
-            traceOut = traces[i];
+        if(traces.length) {
+            traceOut = traces[0];
             binGroupFound = coerce('bingroup');
-            break;
         }
 
         groupName = binGroupFound || groupName;