-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dash R Core Package Unification #243
Changes from 7 commits
32ba6bb
e7c523e
f28adce
e6fcb6e
ccce6ab
2b28268
4946ae6
ea39c8a
fae8c79
3e266c9
2ee8b56
bd6080b
ef6a5c7
227df58
3760784
0ed9eb6
028a5e1
4662f93
b6a4736
9977a3f
f02b125
d8534f4
d66d720
ace5af1
bf0dc69
7a8942b
6601411
c7ee665
5b9f960
0427f28
ec1ab35
fb42f18
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
export(dccChecklist) | ||
export(dccConfirmDialog) | ||
export(dccConfirmDialogProvider) | ||
export(dccDatePickerRange) | ||
export(dccDatePickerSingle) | ||
export(dccDropdown) | ||
export(dccGraph) | ||
export(dccInput) | ||
export(dccInterval) | ||
export(dccLink) | ||
export(dccLoading) | ||
export(dccLocation) | ||
export(dccLogoutButton) | ||
export(dccMarkdown) | ||
export(dccRadioItems) | ||
export(dccRangeSlider) | ||
export(dccSlider) | ||
export(dccStore) | ||
export(dccTab) | ||
export(dccTabs) | ||
export(dccTextarea) | ||
export(dccUpload) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccChecklist <- function(id=NULL, options=NULL, value=NULL, className=NULL, style=NULL, inputStyle=NULL, inputClassName=NULL, labelStyle=NULL, labelClassName=NULL, loading_state=NULL, persistence=NULL, persisted_props=NULL, persistence_type=NULL) { | ||
|
||
props <- list(id=id, options=options, value=value, className=className, style=style, inputStyle=inputStyle, inputClassName=inputClassName, labelStyle=labelStyle, labelClassName=labelClassName, loading_state=loading_state, persistence=persistence, persisted_props=persisted_props, persistence_type=persistence_type) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'Checklist', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'options', 'value', 'className', 'style', 'inputStyle', 'inputClassName', 'labelStyle', 'labelClassName', 'loading_state', 'persistence', 'persisted_props', 'persistence_type'), | ||
package = 'dashCoreComponents' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, my gut feeling is that we probably want to retain the vestigial In other words, right now this is the behaviour, and I'm guessing it should remain as-is: > library(dash)
> library(dashHtmlComponents)
> htmlDiv()
{
"props": {},
"type": "Div",
"namespace": "dash_html_components",
"propNames": ["children", "id", "n_clicks", "n_clicks_timestamp", "key", "role", "accessKey", "className", "contentEditable", "contextMenu", "dir", "draggable", "hidden", "lang", "spellCheck", "style", "tabIndex", "title", "loading_state"],
"package": "dashHtmlComponents"
} @alexcjohnson What are your thoughts? Should we retain the existing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @HammadTheOne Given the reasons outlined in #243 (comment), I believe we'll need to retain the So the JSON returned here should look like this, since the namespace will remain the same, but
|
||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccConfirmDialog <- function(id=NULL, message=NULL, submit_n_clicks=NULL, submit_n_clicks_timestamp=NULL, cancel_n_clicks=NULL, cancel_n_clicks_timestamp=NULL, displayed=NULL) { | ||
|
||
props <- list(id=id, message=message, submit_n_clicks=submit_n_clicks, submit_n_clicks_timestamp=submit_n_clicks_timestamp, cancel_n_clicks=cancel_n_clicks, cancel_n_clicks_timestamp=cancel_n_clicks_timestamp, displayed=displayed) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'ConfirmDialog', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'message', 'submit_n_clicks', 'submit_n_clicks_timestamp', 'cancel_n_clicks', 'cancel_n_clicks_timestamp', 'displayed'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccConfirmDialogProvider <- function(children=NULL, id=NULL, message=NULL, submit_n_clicks=NULL, submit_n_clicks_timestamp=NULL, cancel_n_clicks=NULL, cancel_n_clicks_timestamp=NULL, displayed=NULL, loading_state=NULL) { | ||
|
||
props <- list(children=children, id=id, message=message, submit_n_clicks=submit_n_clicks, submit_n_clicks_timestamp=submit_n_clicks_timestamp, cancel_n_clicks=cancel_n_clicks, cancel_n_clicks_timestamp=cancel_n_clicks_timestamp, displayed=displayed, loading_state=loading_state) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'ConfirmDialogProvider', | ||
namespace = 'dash_core_components', | ||
propNames = c('children', 'id', 'message', 'submit_n_clicks', 'submit_n_clicks_timestamp', 'cancel_n_clicks', 'cancel_n_clicks_timestamp', 'displayed', 'loading_state'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccDatePickerRange <- function(id=NULL, start_date=NULL, start_date_id=NULL, end_date_id=NULL, end_date=NULL, min_date_allowed=NULL, max_date_allowed=NULL, initial_visible_month=NULL, start_date_placeholder_text=NULL, end_date_placeholder_text=NULL, day_size=NULL, calendar_orientation=NULL, is_RTL=NULL, reopen_calendar_on_clear=NULL, number_of_months_shown=NULL, with_portal=NULL, with_full_screen_portal=NULL, first_day_of_week=NULL, minimum_nights=NULL, stay_open_on_select=NULL, show_outside_days=NULL, month_format=NULL, display_format=NULL, disabled=NULL, clearable=NULL, style=NULL, className=NULL, updatemode=NULL, loading_state=NULL, persistence=NULL, persisted_props=NULL, persistence_type=NULL) { | ||
|
||
props <- list(id=id, start_date=start_date, start_date_id=start_date_id, end_date_id=end_date_id, end_date=end_date, min_date_allowed=min_date_allowed, max_date_allowed=max_date_allowed, initial_visible_month=initial_visible_month, start_date_placeholder_text=start_date_placeholder_text, end_date_placeholder_text=end_date_placeholder_text, day_size=day_size, calendar_orientation=calendar_orientation, is_RTL=is_RTL, reopen_calendar_on_clear=reopen_calendar_on_clear, number_of_months_shown=number_of_months_shown, with_portal=with_portal, with_full_screen_portal=with_full_screen_portal, first_day_of_week=first_day_of_week, minimum_nights=minimum_nights, stay_open_on_select=stay_open_on_select, show_outside_days=show_outside_days, month_format=month_format, display_format=display_format, disabled=disabled, clearable=clearable, style=style, className=className, updatemode=updatemode, loading_state=loading_state, persistence=persistence, persisted_props=persisted_props, persistence_type=persistence_type) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'DatePickerRange', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'start_date', 'start_date_id', 'end_date_id', 'end_date', 'min_date_allowed', 'max_date_allowed', 'initial_visible_month', 'start_date_placeholder_text', 'end_date_placeholder_text', 'day_size', 'calendar_orientation', 'is_RTL', 'reopen_calendar_on_clear', 'number_of_months_shown', 'with_portal', 'with_full_screen_portal', 'first_day_of_week', 'minimum_nights', 'stay_open_on_select', 'show_outside_days', 'month_format', 'display_format', 'disabled', 'clearable', 'style', 'className', 'updatemode', 'loading_state', 'persistence', 'persisted_props', 'persistence_type'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccDatePickerSingle <- function(id=NULL, date=NULL, min_date_allowed=NULL, max_date_allowed=NULL, initial_visible_month=NULL, day_size=NULL, calendar_orientation=NULL, is_RTL=NULL, placeholder=NULL, reopen_calendar_on_clear=NULL, number_of_months_shown=NULL, with_portal=NULL, with_full_screen_portal=NULL, first_day_of_week=NULL, stay_open_on_select=NULL, show_outside_days=NULL, month_format=NULL, display_format=NULL, disabled=NULL, clearable=NULL, style=NULL, className=NULL, loading_state=NULL, persistence=NULL, persisted_props=NULL, persistence_type=NULL) { | ||
|
||
props <- list(id=id, date=date, min_date_allowed=min_date_allowed, max_date_allowed=max_date_allowed, initial_visible_month=initial_visible_month, day_size=day_size, calendar_orientation=calendar_orientation, is_RTL=is_RTL, placeholder=placeholder, reopen_calendar_on_clear=reopen_calendar_on_clear, number_of_months_shown=number_of_months_shown, with_portal=with_portal, with_full_screen_portal=with_full_screen_portal, first_day_of_week=first_day_of_week, stay_open_on_select=stay_open_on_select, show_outside_days=show_outside_days, month_format=month_format, display_format=display_format, disabled=disabled, clearable=clearable, style=style, className=className, loading_state=loading_state, persistence=persistence, persisted_props=persisted_props, persistence_type=persistence_type) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'DatePickerSingle', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'date', 'min_date_allowed', 'max_date_allowed', 'initial_visible_month', 'day_size', 'calendar_orientation', 'is_RTL', 'placeholder', 'reopen_calendar_on_clear', 'number_of_months_shown', 'with_portal', 'with_full_screen_portal', 'first_day_of_week', 'stay_open_on_select', 'show_outside_days', 'month_format', 'display_format', 'disabled', 'clearable', 'style', 'className', 'loading_state', 'persistence', 'persisted_props', 'persistence_type'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccDropdown <- function(id=NULL, options=NULL, value=NULL, optionHeight=NULL, className=NULL, clearable=NULL, disabled=NULL, multi=NULL, placeholder=NULL, searchable=NULL, search_value=NULL, style=NULL, loading_state=NULL, persistence=NULL, persisted_props=NULL, persistence_type=NULL) { | ||
|
||
props <- list(id=id, options=options, value=value, optionHeight=optionHeight, className=className, clearable=clearable, disabled=disabled, multi=multi, placeholder=placeholder, searchable=searchable, search_value=search_value, style=style, loading_state=loading_state, persistence=persistence, persisted_props=persisted_props, persistence_type=persistence_type) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'Dropdown', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'options', 'value', 'optionHeight', 'className', 'clearable', 'disabled', 'multi', 'placeholder', 'searchable', 'search_value', 'style', 'loading_state', 'persistence', 'persisted_props', 'persistence_type'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccGraph <- function(id=NULL, responsive=NULL, clickData=NULL, clickAnnotationData=NULL, hoverData=NULL, clear_on_unhover=NULL, selectedData=NULL, relayoutData=NULL, extendData=NULL, prependData=NULL, restyleData=NULL, figure=NULL, style=NULL, className=NULL, animate=NULL, animation_options=NULL, config=NULL, loading_state=NULL) { | ||
|
||
props <- list(id=id, responsive=responsive, clickData=clickData, clickAnnotationData=clickAnnotationData, hoverData=hoverData, clear_on_unhover=clear_on_unhover, selectedData=selectedData, relayoutData=relayoutData, extendData=extendData, prependData=prependData, restyleData=restyleData, figure=figure, style=style, className=className, animate=animate, animation_options=animation_options, config=config, loading_state=loading_state) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'Graph', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'responsive', 'clickData', 'clickAnnotationData', 'hoverData', 'clear_on_unhover', 'selectedData', 'relayoutData', 'extendData', 'prependData', 'restyleData', 'figure', 'style', 'className', 'animate', 'animation_options', 'config', 'loading_state'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccInput <- function(id=NULL, value=NULL, style=NULL, className=NULL, debounce=NULL, type=NULL, autoComplete=NULL, autoFocus=NULL, disabled=NULL, inputMode=NULL, list=NULL, max=NULL, maxLength=NULL, min=NULL, minLength=NULL, multiple=NULL, name=NULL, pattern=NULL, placeholder=NULL, readOnly=NULL, required=NULL, selectionDirection=NULL, selectionEnd=NULL, selectionStart=NULL, size=NULL, spellCheck=NULL, step=NULL, n_submit=NULL, n_submit_timestamp=NULL, n_blur=NULL, n_blur_timestamp=NULL, loading_state=NULL, persistence=NULL, persisted_props=NULL, persistence_type=NULL) { | ||
|
||
props <- list(id=id, value=value, style=style, className=className, debounce=debounce, type=type, autoComplete=autoComplete, autoFocus=autoFocus, disabled=disabled, inputMode=inputMode, list=list, max=max, maxLength=maxLength, min=min, minLength=minLength, multiple=multiple, name=name, pattern=pattern, placeholder=placeholder, readOnly=readOnly, required=required, selectionDirection=selectionDirection, selectionEnd=selectionEnd, selectionStart=selectionStart, size=size, spellCheck=spellCheck, step=step, n_submit=n_submit, n_submit_timestamp=n_submit_timestamp, n_blur=n_blur, n_blur_timestamp=n_blur_timestamp, loading_state=loading_state, persistence=persistence, persisted_props=persisted_props, persistence_type=persistence_type) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'Input', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'value', 'style', 'className', 'debounce', 'type', 'autoComplete', 'autoFocus', 'disabled', 'inputMode', 'list', 'max', 'maxLength', 'min', 'minLength', 'multiple', 'name', 'pattern', 'placeholder', 'readOnly', 'required', 'selectionDirection', 'selectionEnd', 'selectionStart', 'size', 'spellCheck', 'step', 'n_submit', 'n_submit_timestamp', 'n_blur', 'n_blur_timestamp', 'loading_state', 'persistence', 'persisted_props', 'persistence_type'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccInterval <- function(id=NULL, interval=NULL, disabled=NULL, n_intervals=NULL, max_intervals=NULL) { | ||
|
||
props <- list(id=id, interval=interval, disabled=disabled, n_intervals=n_intervals, max_intervals=max_intervals) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'Interval', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'interval', 'disabled', 'n_intervals', 'max_intervals'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccLink <- function(children=NULL, id=NULL, href=NULL, refresh=NULL, className=NULL, style=NULL, title=NULL, target=NULL, loading_state=NULL) { | ||
|
||
props <- list(children=children, id=id, href=href, refresh=refresh, className=className, style=style, title=title, target=target, loading_state=loading_state) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'Link', | ||
namespace = 'dash_core_components', | ||
propNames = c('children', 'id', 'href', 'refresh', 'className', 'style', 'title', 'target', 'loading_state'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccLoading <- function(children=NULL, id=NULL, type=NULL, fullscreen=NULL, debug=NULL, className=NULL, parent_className=NULL, style=NULL, parent_style=NULL, color=NULL, loading_state=NULL) { | ||
|
||
props <- list(children=children, id=id, type=type, fullscreen=fullscreen, debug=debug, className=className, parent_className=parent_className, style=style, parent_style=parent_style, color=color, loading_state=loading_state) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'Loading', | ||
namespace = 'dash_core_components', | ||
propNames = c('children', 'id', 'type', 'fullscreen', 'debug', 'className', 'parent_className', 'style', 'parent_style', 'color', 'loading_state'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccLocation <- function(id=NULL, pathname=NULL, search=NULL, hash=NULL, href=NULL, refresh=NULL) { | ||
|
||
props <- list(id=id, pathname=pathname, search=search, hash=hash, href=href, refresh=refresh) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'Location', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'pathname', 'search', 'hash', 'href', 'refresh'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccLogoutButton <- function(id=NULL, label=NULL, logout_url=NULL, style=NULL, method=NULL, className=NULL, loading_state=NULL) { | ||
|
||
props <- list(id=id, label=label, logout_url=logout_url, style=style, method=method, className=className, loading_state=loading_state) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'LogoutButton', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'label', 'logout_url', 'style', 'method', 'className', 'loading_state'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccMarkdown <- function(children=NULL, id=NULL, className=NULL, dangerously_allow_html=NULL, dedent=NULL, highlight_config=NULL, loading_state=NULL, style=NULL) { | ||
|
||
props <- list(children=children, id=id, className=className, dangerously_allow_html=dangerously_allow_html, dedent=dedent, highlight_config=highlight_config, loading_state=loading_state, style=style) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'Markdown', | ||
namespace = 'dash_core_components', | ||
propNames = c('children', 'id', 'className', 'dangerously_allow_html', 'dedent', 'highlight_config', 'loading_state', 'style'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# AUTO GENERATED FILE - DO NOT EDIT | ||
|
||
dccRadioItems <- function(id=NULL, options=NULL, value=NULL, style=NULL, className=NULL, inputStyle=NULL, inputClassName=NULL, labelStyle=NULL, labelClassName=NULL, loading_state=NULL, persistence=NULL, persisted_props=NULL, persistence_type=NULL) { | ||
|
||
props <- list(id=id, options=options, value=value, style=style, className=className, inputStyle=inputStyle, inputClassName=inputClassName, labelStyle=labelStyle, labelClassName=labelClassName, loading_state=loading_state, persistence=persistence, persisted_props=persisted_props, persistence_type=persistence_type) | ||
if (length(props) > 0) { | ||
props <- props[!vapply(props, is.null, logical(1))] | ||
} | ||
component <- list( | ||
props = props, | ||
type = 'RadioItems', | ||
namespace = 'dash_core_components', | ||
propNames = c('id', 'options', 'value', 'style', 'className', 'inputStyle', 'inputClassName', 'labelStyle', 'labelClassName', 'loading_state', 'persistence', 'persisted_props', 'persistence_type'), | ||
package = 'dashCoreComponents' | ||
) | ||
|
||
structure(component, class = c('dash_component', 'list')) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the creation and commission of the
gulp-assets
folder intentional? If it's possible to relocate the resources in-place once, that would be ideal (e.g. things destined forR
,man
,inst
are copied intodash
as needed and artifacts are committed only once to their final destination).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main point of having a dedicated directory was for ease of development and updates - for any DashR releases or version updates for the component packages, we can simply copy over the existing component directories to
gulp-assets
and run theupdate
script to move the assets within to their respective dependency directories.I do want to take another pass over this and maybe make it a little more like the
dash
build process so there's less relocation.