cwd for running dashr tests - auto and override #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronz
reviewed
Oct 7, 2019
byronz
reviewed
Oct 7, 2019
rpkyle
reviewed
Oct 7, 2019
There was a problem hiding this comment.
@alexcjohnson The fix works for me; locally I can 🔪 os.chdir and successfully execute the test from within its own directory, as well as outside of it.
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 28, 2021
Add disabled_days prop to datepickers
HammadTheOne
pushed a commit
that referenced
this pull request
Jul 23, 2021
Add disabled_days prop to datepickers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rpkyle with any luck this will let you remove that
os.chdircall intest_clientside.py.Sets the cwd for R test apps during the
subprocess.Popencall - so it won't affect any other tests. If the app was provided as a string, it tries to find the directory of the calling Python file and use that as cwd. If it was provided as a path to a file it just uses the directory of that file. Either way you can override this behavior withdashr.start_server(app, cwd='/some/path/')optionals
CHANGELOG.md