Fix collections.abc deprecation warning for py 3.8 #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
changed the title
T4rk1n
force-pushed
the
fix-component-abc
branch
from
5a954e1 to
898ac22
Compare
T4rk1n
force-pushed
the
fix-component-abc
branch
from
898ac22 to
ddac3c7
Compare
|
@alexcjohnson Please review. |
T4rk1n
changed the title
alexcjohnson
reviewed
Feb 1, 2019
| def patch_collections_abc(member): | ||
| if six.PY2: | ||
| return getattr(collections, member) | ||
| return getattr(collections.abc, member) |
There was a problem hiding this comment.
Ah yep, that'll work. But why did you do it this way rather than just return collections or return collections.abc, so you could use it as patch_collections_abc.Callable?
There was a problem hiding this comment.
You have a member that is different by name which is a string, this consider the module like a dict. Other solution would work too but I came up with this first.
alexcjohnson
approved these changes
Feb 1, 2019
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 28, 2021
* Don't attempt to resize unmounted graphs Fixes #534 * Anon resize function -> named bound function; add removeEventListener * Add additional gd conditional in plot() * Add integration test for resizing unmounted graphs * Add changelog entry for PR plotly#563 (Don't attempt to resize unmounted graphs) * black for test_integration.py * CHANGELOG ticks
AnnMarieW
pushed a commit
to AnnMarieW/dash
that referenced
this pull request
Jan 6, 2022
* Don't attempt to resize unmounted graphs Fixes #534 * Anon resize function -> named bound function; add removeEventListener * Add additional gd conditional in plot() * Add integration test for resizing unmounted graphs * Add changelog entry for PR plotly#563 (Don't attempt to resize unmounted graphs) * black for test_integration.py * CHANGELOG ticks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562