Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assets_url_path in get_asset_url. #374

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Use assets_url_path in get_asset_url. #374

merged 2 commits into from
Sep 10, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Sep 7, 2018

Fix #373, use assets_url_path in get_asset_url.

@T4rk1n T4rk1n requested review from ned2 and michaelbabyn September 7, 2018 19:50
@ned2
Copy link
Contributor

ned2 commented Sep 8, 2018

looks good 💃

@T4rk1n T4rk1n force-pushed the fix-assets-url-path branch from e91f6f8 to 7e075d1 Compare September 10, 2018 15:25
@T4rk1n T4rk1n merged commit dbcb2a1 into master Sep 10, 2018
@T4rk1n T4rk1n deleted the fix-assets-url-path branch September 10, 2018 15:35
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
@Marc-Andre-Rivet
- add license to manifest (plotly#374)
d645c15
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
@Marc-Andre-Rivet
- add license to manifest (#374)
8290720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned2 ned2 ned2 approved these changes

@michaelbabyn michaelbabyn Awaiting requested review from michaelbabyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T4rk1n @ned2