Graph edit queue #2237
Merged
Graph edit queue #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plotly.js rendering in
dcc.Graphcan be async - more so now that we support MathJax in Dash, though there were always some async things like loading geojson. Anyway this hasn't caused any problems in core dash that I'm aware of, but in dash-design-kit, which wrapsdcc.Graphand passes some information back and forth for theming purposes,extendDataandprependDatacould cause tworendercycles to overlap and drop the new data. This ensures theplotly.jsmethod calls are sequenced properly, even if they end up delayed relative to the React renders. In my testing the changes here fix DDK (separate PR coming there) and it may fix some as-yet-undiscovered bugs in core DCC.CHANGELOG.md