Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert 2126 until fixed #2168

Merged
merged 3 commits into from
Aug 1, 2022
Merged

revert 2126 until fixed #2168

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d8f35e
revert 2126 until fixed
AnnMarieW Jul 25, 2022
97c79b3
added changelog entry
AnnMarieW Jul 26, 2022
982d7d1
Update CHANGELOG.md
AnnMarieW Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
## [UNRELEASED]

- [#2146](https://github.com/plotly/dash/pull/2146) Remove leftover debug console.log statement.
- [#2168](https://github.com/plotly/dash/pull/2168) Reverts [#2126](https://github.com/plotly/dash/pull/2126) until the new bugs introduced by that PR are fixed.

## [2.6.0] - 2022-07-14

Expand Down
8 changes: 1 addition & 7 deletions dash/dash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,8 +556,7 @@ def _handle_error(_):
self._add_url("_dash-update-component", self.dispatch, ["POST"])
self._add_url("_reload-hash", self.serve_reload_hash)
self._add_url("_favicon.ico", self._serve_default_favicon)
if not self.use_pages:
self._add_url("", self.index)
self._add_url("", self.index)

# catch-all for front-end routes, used by dcc.Location
self._add_url("<path:path>", self.index)
Expand Down Expand Up @@ -2119,11 +2118,6 @@ def redirect():
fullname,
create_redirect_function(page["relative_path"]),
)
# set "/" if not redirected
try:
self._add_url("", self.index)
except AssertionError:
pass

def run_server(self, *args, **kwargs):
"""`run_server` is a deprecated alias of `run` and may be removed in a
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/test_pages_redirect_home.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import dash
import pytest


def test_pare001_redirect_home(dash_duo):
pytest.skip("Revisit later")

app = dash.Dash(__name__, use_pages=True, pages_folder="")

Expand Down