Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed pages to exclude files starting with . #2102

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

AnnMarieW
Copy link
Collaborator

  • Fix bug as reported in dash-labs 113 where files starting with . were not excluded when building dash.page_registry.

  • Removed usage-pages file

  • I have run the tests locally and they passed. (refer to testing section in contributing)

  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md

@AnnMarieW AnnMarieW requested a review from alexcjohnson as a code owner June 21, 2022 20:36
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! 💃

@alexcjohnson alexcjohnson merged commit 7558567 into plotly:dev Jun 28, 2022
@AnnMarieW AnnMarieW deleted the fix-pages-exclude-files branch June 28, 2022 13:40
@charmeem
Copy link

charmeem commented Jul 6, 2022

Like to know in which release this fix will be included.

@alexcjohnson
Copy link
Collaborator

hoping to have this release (2.6.0) out by the end of the week.

@charmeem
Copy link

charmeem commented Aug 4, 2022

I have upgraded to 2.6.0 but this issues does not seems to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants