Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long callback refactor #2039

Merged
merged 41 commits into from
Jun 30, 2022
Merged

Long callback refactor #2039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
bfbd59e
Handle long callback errors.
T4rk1n Apr 26, 2022
dbacfcc
:hankey: Add test long callback error.
T4rk1n Apr 26, 2022
ac59e59
Add lock to diskcache
T4rk1n May 6, 2022
e2d3d5e
Fix test long callback error.
T4rk1n May 6, 2022
c3855ef
Merge branch 'dev' into long-callback-errors
T4rk1n May 6, 2022
fb4cef9
Handle no update in celery long callbacks.
T4rk1n May 6, 2022
fa94a40
Use diskcache lock
T4rk1n May 9, 2022
7688306
Stricter no_update check.
T4rk1n May 9, 2022
20c72b9
Handle no update in multi output.
T4rk1n May 9, 2022
2f9fe06
Add long callback test lock.
T4rk1n May 9, 2022
9ed5a3f
Merge branch 'dev' into long-callback-errors
T4rk1n May 17, 2022
9cab5b4
Clean up no_update.
T4rk1n May 17, 2022
9509213
Merge branch 'dev' into long-callback-errors
T4rk1n Jun 10, 2022
3a207ce
Merge branch 'dev' into long-callback-errors
T4rk1n Jun 13, 2022
2b22ff3
Replace long callback interval with request polling handled in renderer.
T4rk1n Jun 13, 2022
c5f6fff
Fix test_grouped_callbacks
T4rk1n Jun 13, 2022
fc9a77b
Fix cbva002
T4rk1n Jun 14, 2022
40bd173
Fix celery cancel.
T4rk1n Jun 14, 2022
28a6d77
Fix callback_map
T4rk1n Jun 14, 2022
1c1c7a2
Update callback docstrings.
T4rk1n Jun 15, 2022
55455f9
Add test short interval.
T4rk1n Jun 15, 2022
cc9b09b
Add error if no manager.
T4rk1n Jun 15, 2022
0501fd9
Fix error message assert
T4rk1n Jun 15, 2022
43e42ea
Remove leftover _NoUpdate.
T4rk1n Jun 20, 2022
de5ee34
Update dash/dash.py
T4rk1n Jun 20, 2022
08356f0
Hide arguments.
T4rk1n Jun 20, 2022
edd7fd6
Add test side update.
T4rk1n Jun 21, 2022
2fd56e9
Redux devtools ignore reloadRequest actions.
T4rk1n Jun 21, 2022
da2b01f
Long callbacks side update to trigger other callbacks.
T4rk1n Jun 21, 2022
bfc3c8f
Add test long callback pattern matching.
T4rk1n Jun 21, 2022
077733c
Add circular check for long callbacks side outputs.
T4rk1n Jun 21, 2022
638dacf
Add test long callback context.
T4rk1n Jun 21, 2022
9df3082
Support callback context in long callbacks.
T4rk1n Jun 21, 2022
ccb53b9
Proper callback_context, replace flask.g context with contextvars.
T4rk1n Jun 22, 2022
8525c73
Fix cancel.
T4rk1n Jun 23, 2022
34bd81d
Back to flask.g for timing_information.
T4rk1n Jun 23, 2022
b2ac6ce
Merge branch 'dev' into long-callback-errors
T4rk1n Jun 23, 2022
02c15dc
Manage previous outdated running jobs.
T4rk1n Jun 28, 2022
a003f5a
Merge branch 'dev' into long-callback-errors
T4rk1n Jun 29, 2022
529ec8e
Lock selenium <=4.2.0
T4rk1n Jun 30, 2022
2fb1cfa
Update changelog.
T4rk1n Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@ This project adheres to [Semantic Versioning](https://semver.org/).
- [#2098](https://github.com/plotly/dash/pull/2098) Accept HTTP code 400 as well as 401 for JWT expiry
- [#2097](https://github.com/plotly/dash/pull/2097) Fix bug [#2095](https://github.com/plotly/dash/issues/2095) with TypeScript compiler and `React.FC` empty valueDeclaration error & support empty props components.
- [#2104](https://github.com/plotly/dash/pull/2104) Fix bug [#2099](https://github.com/plotly/dash/issues/2099) with Dropdown clearing search value when a value is selected.
- [#2039](https://github.com/plotly/dash/pull/2039) Fix bugs in long callbacks:
- Fix [#1769](https://github.com/plotly/dash/issues/1769) and [#1852](https://github.com/plotly/dash/issues/1852) short interval makes job run in loop.
- Fix [#1974](https://github.com/plotly/dash/issues/1974) returning `no_update` or raising `PreventUpdate` not supported with celery.
- Fix use of the callback context in celery long callbacks.
- Fix support of pattern matching for long callbacks.

### Added

- [#2039](https://github.com/plotly/dash/pull/2039) Long callback changes:
- Add `long=False` to `dash.callback` to use instead of `app.long_callback`.
- Add previous `app.long_callback` arguments to `dash.callback` prefixed with `long_` (`interval`, `running`, `cancel`, `progress`, `progress_default`, `cache_args_to_ignore`, `manager`)

## [2.5.1] - 2022-06-13

Expand Down
Loading