Change `get_current_traceback` to `DebugTraceback` #1993

deepyaman · 2022-03-28T19:24:55Z

Closes #1992

It's not an option to change get_current_traceback to DebugTraceback entirely because Werkzeug==2.1.0 requires Python 3.7, but we can backport a minimal DebugTraceback to earlier versions of Werkzeug.

Contributor Checklist

I have broken down my PR scope into the following TODO tasks
- task 1
- task 2
I have run the tests locally and they passed. (refer to testing section in contributing)
I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md
If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
- this GitHub #PR number updates the dash docs
- here is the show and tell thread in Plotly Dash community

deepyaman · 2022-03-28T19:34:40Z

~~Closing this PR, as upgrading to Werkzeug 2.1.0 would mean dropping support for Python 3.6, which is a much bigger decision.~~

requires-install.txt

requires-all.txt

CHANGELOG.md

flying-sheep

Version upper bounds are no good approach for library projects: https://iscinumpy.dev/post/bound-version-constraints/

You should instead write conditional code handling all flask/werkzeug versions or (if that’s too hard) drop Python 3.6 support

deepyaman · 2022-03-29T11:33:36Z

Version upper bounds are no good approach for library projects: https://iscinumpy.dev/post/bound-version-constraints/

You should instead write conditional code handling all flask/werkzeug versions or (if that’s too hard) drop Python 3.6 support

@flying-sheep I can do either. I don't see much examples of conditional Python version handling within Dash (only

dash/dash/development/component_generator.py

Line 154 in 3334c07

if sys.version_info[0] >= 3:

outside of tests, but even that's for a component generator), but I've seen plenty of it in other libraries. I would personally also be fine to drop 3.6, but don't think that's my call.

Are you one of the maintainers of Dash? Just want to makes sure the change is aligned with whoever will be making the final call.

flying-sheep · 2022-03-29T11:48:10Z

I’m not, sorry if I gave the impression. I think you can see that by the color of my review icon: mine is gray, so it’s just a “suggested change” and not a “requested change”.

I’m just speaking from my history of dealing with compatibility problems and bugs in python libraries. That blog post I linked really nails it IMHO, and I think any library maintainer should read it. Upper version bounds just cause too many problems for too many people.

deepyaman · 2022-03-29T12:15:27Z

I’m not, sorry if I gave the impression. I think you can see that by the color of my review icon: mine is gray, so it’s just a “suggested change” and not a “requested change”.

I’m just speaking from my history of dealing with compatibility problems and bugs in python libraries. That blog post I linked really nails it IMHO, and I think any library maintainer should read it. Upper version bounds just cause too many problems for too many people.

No worries, and thanks for the article link--I've been going through it and sharing it to my colleagues, since there's a lot of great stuff with examples in there!!

This reverts commit 206b31d.

This reverts commit 225faba.

This reverts commit c763231.

This reverts commit 1c1a933.

This reverts commit 107c074.

This reverts commit 731d9e5.

This reverts commit 8a50189.

T4rk1n · 2022-03-29T13:02:21Z

I think we can drop support for Python 3.6 in later releases, it's been end of life for a few months now and more libraries will stop working as they drop support. What do you think @alexcjohnson ?

alexcjohnson · 2022-03-29T14:54:16Z

Py3.6 still accounts for about 10% of our downloads so I don't think it's time to drop it yet. 3.7 is still the most used though it's about to lose that title to 3.8 finally.

requires-all.txt

requires-ci.txt

Fix for ImportError: cannot import name 'get_current_traceback' from 'werkzeug.debug.tbtools' conflict with dash for studio celery-beat | from .dash_demo import app celery-beat | File "/app/monitor/dash_demo.py", line 8, in <module> celery-beat | import dash celery-beat | File "/usr/local/lib/python3.8/site-packages/dash/__init__.py", line 5, in <module> celery-beat | from .dash import Dash, no_update # noqa: F401,E402 celery-beat | File "/usr/local/lib/python3.8/site-packages/dash/dash.py", line 22, in <module> celery-beat | from werkzeug.debug.tbtools import get_current_traceback celery-beat | ImportError: cannot import name 'get_current_traceback' from 'werkzeug.debug.tbtools' (/usr/local/lib/python3.8/site-packages/werkzeug/debug/tbtools.py) Ref: plotly/dash#1993

alexcjohnson · 2022-03-29T21:00:05Z

Thanks @deepyaman - we ended up going with #1995 so I'll close this one but your work here was helpful toward fully understanding the issue!

Fix for ImportError: cannot import name 'get_current_traceback' from 'werkzeug.debug.tbtools' conflict with dash for studio celery-beat | from .dash_demo import app celery-beat | File "/app/monitor/dash_demo.py", line 8, in <module> celery-beat | import dash celery-beat | File "/usr/local/lib/python3.8/site-packages/dash/__init__.py", line 5, in <module> celery-beat | from .dash import Dash, no_update # noqa: F401,E402 celery-beat | File "/usr/local/lib/python3.8/site-packages/dash/dash.py", line 22, in <module> celery-beat | from werkzeug.debug.tbtools import get_current_traceback celery-beat | ImportError: cannot import name 'get_current_traceback' from 'werkzeug.debug.tbtools' (/usr/local/lib/python3.8/site-packages/werkzeug/debug/tbtools.py) Reproduce the error: 1- Install stackn (docker-compose up) Ref: plotly/dash#1993

Update dash.py

37f289a

deepyaman changed the title ~~Update dash.py~~ Change get_current_traceback to DebugTraceback Mar 28, 2022

deepyaman closed this Mar 28, 2022

deepyaman added 3 commits March 28, 2022 15:38

Update requires-all.txt

8a50189

Update requires-install.txt

731d9e5

Update dash.py

107c074

deepyaman reopened this Mar 28, 2022

deepyaman changed the title ~~Change get_current_traceback to DebugTraceback~~ Pin Flask<2.1.0 to retain Python 3.6 compatibility Mar 28, 2022

deepyaman added 2 commits March 28, 2022 15:51

Update requires-install.txt

1c1a933

Update requires-all.txt

c763231

deepyaman changed the title ~~Pin Flask<2.1.0 to retain Python 3.6 compatibility~~ Pin Flask<2.1.0 and Werkzeug<2.1.0 to retain Python 3.6 compatibility Mar 28, 2022

deepyaman marked this pull request as ready for review March 28, 2022 19:54

deepyaman requested a review from alexcjohnson as a code owner March 28, 2022 19:54

Update CHANGELOG.md

225faba

deepyaman commented Mar 28, 2022

View reviewed changes

requires-install.txt Outdated Show resolved Hide resolved

deepyaman commented Mar 28, 2022

View reviewed changes

requires-all.txt Outdated Show resolved Hide resolved

deepyaman commented Mar 28, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Pin click<8.1.0 to retain Python 3.6 compatibility

206b31d

deepyaman changed the title ~~Pin Flask<2.1.0 and Werkzeug<2.1.0 to retain Python 3.6 compatibility~~ Pin Flask<2.1.0, Werkzeug<2.1.0, and click<8.1.0 to retain Python 3.6 compatibility Mar 28, 2022

deepyaman mentioned this pull request Mar 28, 2022

ImportError: cannot import name 'get_current_traceback' from 'werkzeug.debug.tbtools' #1992

Closed

flying-sheep suggested changes Mar 29, 2022

View reviewed changes

deepyaman added 5 commits March 29, 2022 08:58

Revert "Pin click<8.1.0 to retain Python 3.6 compatibility"

2fc1e3d

This reverts commit 206b31d.

Revert "Update CHANGELOG.md"

b5ec4f7

This reverts commit 225faba.

Revert "Update requires-all.txt"

c9b6af9

This reverts commit c763231.

Revert "Update requires-install.txt"

89e9538

This reverts commit 1c1a933.

Revert "Update dash.py"

a3d5e6d

This reverts commit 107c074.

deepyaman added 2 commits March 29, 2022 08:59

Revert "Update requires-install.txt"

8a74176

This reverts commit 731d9e5.

Revert "Update requires-all.txt"

87598a0

This reverts commit 8a50189.

If werkzeug<2.1.0, mock minimal DebugTraceback

1eb6fd8

deepyaman changed the title ~~Pin Flask<2.1.0, Werkzeug<2.1.0, and click<8.1.0 to retain Python 3.6 compatibility~~ Change get_current_traceback to DebugTraceback Mar 29, 2022

Upgrade black version in CI to be click-compatible

b2e5b67

deepyaman commented Mar 29, 2022

View reviewed changes

requires-all.txt Outdated Show resolved Hide resolved

deepyaman commented Mar 29, 2022

View reviewed changes

requires-ci.txt Outdated Show resolved Hide resolved

deepyaman added 3 commits March 29, 2022 15:48

Condition black version on python version

c1a9dbf

Black

5b2c4d0

Merge branch 'patch-1' of https://github.com/deepyaman/dash into patch-1

9b108ef

aitmlouk mentioned this pull request Mar 29, 2022

Fix ImportError: 'get_current_traceback' from 'werkzeug.debug.tbtools' scaleoutsystems/stackn#264

Closed

16 tasks

alexcjohnson closed this Mar 29, 2022

deepyaman deleted the patch-1 branch March 29, 2022 21:29

aitmlouk mentioned this pull request Mar 30, 2022

Patch 2 scaleoutsystems/stackn#266

Closed

16 tasks

aitmlouk mentioned this pull request Apr 2, 2022

Fix ImportError: 'get_current_traceback' from 'werkzeug.debug.tbtools' scaleoutsystems/stackn#267

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change `get_current_traceback` to `DebugTraceback` #1993

Change `get_current_traceback` to `DebugTraceback` #1993

deepyaman commented Mar 28, 2022 •

edited

Loading

deepyaman commented Mar 28, 2022 •

edited

Loading

flying-sheep left a comment

deepyaman commented Mar 29, 2022

flying-sheep commented Mar 29, 2022 •

edited

Loading

deepyaman commented Mar 29, 2022

T4rk1n commented Mar 29, 2022 •

edited

Loading

alexcjohnson commented Mar 29, 2022

alexcjohnson commented Mar 29, 2022

Change get_current_traceback to DebugTraceback #1993

Change get_current_traceback to DebugTraceback #1993

Conversation

deepyaman commented Mar 28, 2022 • edited Loading

Contributor Checklist

optionals

deepyaman commented Mar 28, 2022 • edited Loading

flying-sheep left a comment

Choose a reason for hiding this comment

deepyaman commented Mar 29, 2022

flying-sheep commented Mar 29, 2022 • edited Loading

deepyaman commented Mar 29, 2022

T4rk1n commented Mar 29, 2022 • edited Loading

alexcjohnson commented Mar 29, 2022

alexcjohnson commented Mar 29, 2022

Change `get_current_traceback` to `DebugTraceback` #1993

Change `get_current_traceback` to `DebugTraceback` #1993

deepyaman commented Mar 28, 2022 •

edited

Loading

deepyaman commented Mar 28, 2022 •

edited

Loading

flying-sheep commented Mar 29, 2022 •

edited

Loading

T4rk1n commented Mar 29, 2022 •

edited

Loading