-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SVG rendering of equations in dcc.Graph
and dcc.Markdown
using MathJax
v3
#1949
Conversation
inlineMath: props => ( | ||
<Math tex={props.value} inline={true} /> | ||
), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @anders-kiaer for the contribution in 🏆 🏆 🏆 plotly/dash-core-components#634 🏆 🏆 🏆
components/dash-core-components/tests/integration/markdown/test_markdown.py
Outdated
Show resolved
Hide resolved
components/dash-core-components/tests/integration/markdown/test_markdown.py
Outdated
Show resolved
Hide resolved
components/dash-core-components/tests/integration/markdown/test_markdown.py
Outdated
Show resolved
Hide resolved
components/dash-core-components/tests/integration/graph/test_graph_varia.py
Outdated
Show resolved
Hide resolved
components/dash-core-components/tests/integration/graph/test_graph_varia.py
Outdated
Show resolved
Hide resolved
…t_markdown.py Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
…t_markdown.py Co-authored-by: Alex Johnson <[email protected]>
…raph_varia.py Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
…t_markdown.py Co-authored-by: Alex Johnson <[email protected]>
…t_markdown.py Co-authored-by: Alex Johnson <[email protected]>
components/dash-core-components/tests/integration/markdown/test_markdown.py
Show resolved
Hide resolved
components/dash-core-components/tests/integration/markdown/test_markdown.py
Outdated
Show resolved
Hide resolved
components/dash-core-components/tests/integration/markdown/test_markdown.py
Show resolved
Hide resolved
components/dash-core-components/tests/integration/markdown/test_markdown.py
Show resolved
Hide resolved
…t_markdown.py Co-authored-by: Alex Johnson <[email protected]>
components/dash-core-components/src/utils/LazyLoader/mathjax.js
Outdated
Show resolved
Hide resolved
@alexcjohnson How does the percy image test for MathJax look like? |
Looks good! Some parts of the graphs are grossly misaligned, but that's unfortunately normal for percy, we're missing some CSS from plotly.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Fantastic work @archmoj!
Also bumping
plotly.js
tov2.10.1
.See additions and fixes in v2.10.0 and v2.10.1.
Example app: