Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE11 #1932

Merged
merged 10 commits into from
Feb 18, 2022
Merged

Fix IE11 #1932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5268595
tweak update_components script to exit on all failures
alexcjohnson Feb 17, 2022
5b3745d
IE11 compatibility for renderer, dcc, table
alexcjohnson Feb 17, 2022
9e92714
remove webdriver-manager
alexcjohnson Feb 17, 2022
f5a9a0c
fix #1914 - text alignment in table headers
alexcjohnson Feb 17, 2022
514eb54
changelog for ie11 fix PR
alexcjohnson Feb 17, 2022
ef8bf17
tweak header css and add a test
alexcjohnson Feb 17, 2022
f2f57b7
simplify table visual tests a bit
alexcjohnson Feb 17, 2022
49d2924
Merge branch 'dev' into fix-ie11
alexcjohnson Feb 17, 2022
2f70e59
Merge branch 'dev' into fix-ie11
alexcjohnson Feb 17, 2022
451ea2f
wider table column actions test - since we aren't auto-wrapping these…
alexcjohnson Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ This project adheres to [Semantic Versioning](https://semver.org/).
- Adds `ticklabelstep` to axes to reduce tick labels while still showing all ticks.
- Displays the plotly.js version when hovering on the modebar. This helps debugging situations where there might be multiple sources of plotly.js, for example `/assets` vs the versions built into `dcc` or `ddk`.

### Fixed
- [#1932](https://github.com/plotly/dash/pull/1932) Fixes several bugs:
- Restores compatibility with IE11 [#1925](https://github.com/plotly/dash/issues/1925)
- Restores `style_header` text alignment in Dash Table [#1914](https://github.com/plotly/dash/issues/1914)
- Clears the unneeded `webdriver-manager` requirement from `dash[testing]` [#1919](https://github.com/plotly/dash/issues/1925)

## [2.1.0] - 2022-01-22

### Changed
Expand Down
66 changes: 33 additions & 33 deletions components/dash-core-components/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions components/dash-core-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
"maintainer": "Alex Johnson <[email protected]>",
"license": "MIT",
"dependencies": {
"@fortawesome/fontawesome-svg-core": "^1.3.0",
"@fortawesome/free-regular-svg-icons": "^6.0.0",
"@fortawesome/free-solid-svg-icons": "^6.0.0",
"@fortawesome/fontawesome-svg-core": "1.2.36",
"@fortawesome/free-regular-svg-icons": "^5.15.4",
"@fortawesome/free-solid-svg-icons": "^5.15.4",
"@fortawesome/react-fontawesome": "^0.1.17",
"base64-js": "^1.5.1",
"color": "^4.2.1",
Expand Down
3 changes: 2 additions & 1 deletion components/dash-core-components/src/fragments/Graph.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, {Component} from 'react';
import ResizeDetector from 'react-resize-detector';
// /build/withPolyfill for IE11 support - https://github.com/maslianok/react-resize-detector/issues/144
import ResizeDetector from 'react-resize-detector/build/withPolyfill';
import {
equals,
filter,
Expand Down
66 changes: 33 additions & 33 deletions components/dash-table/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions components/dash-table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@
"@babel/polyfill": "^7.12.1",
"@babel/preset-env": "^7.16.11",
"@babel/preset-react": "^7.16.7",
"@fortawesome/fontawesome-svg-core": "^1.3.0",
"@fortawesome/free-regular-svg-icons": "^6.0.0",
"@fortawesome/free-solid-svg-icons": "^6.0.0",
"@fortawesome/fontawesome-svg-core": "1.2.36",
"@fortawesome/free-regular-svg-icons": "^5.15.4",
"@fortawesome/free-solid-svg-icons": "^5.15.4",
"@fortawesome/react-fontawesome": "^0.1.17",
"@percy/storybook": "^3.3.1",
"@plotly/dash-component-plugins": "^1.2.2",
Expand Down
3 changes: 1 addition & 2 deletions components/dash-table/src/dash-table/components/Table/Table.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,11 +703,10 @@
}
.column-actions {
display: flex;
flex-wrap: wrap;
}

.column-header-name {
margin-left: auto;
flex-grow: 1;
}

[class^='column-header--'], [class^='dash-filter--'] {
Expand Down
2 changes: 2 additions & 0 deletions components/dash-table/src/dash-table/components/Table/style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// NOTE: need to pin fontawesome-svg-core to <1.3 and free-*-svg-icons to <6
// or we break IE11
import {library} from '@fortawesome/fontawesome-svg-core';
import {faEyeSlash, faTrashAlt} from '@fortawesome/free-regular-svg-icons';
import {
Expand Down
3 changes: 3 additions & 0 deletions components/dash-table/tests/selenium/test_column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ def get_app(props=dict()):
baseProps["filter_action"] = "native"
baseProps["merge_duplicate_headers"] = True

# first col is normally only 60px, make it wider since we're adding
# all these actions and need to interact with them
baseProps["style_cell_conditional"][0].update(width=120, maxWidth=120, minWidth=120)
baseProps.update(props)

app.layout = DataTable(**baseProps)
Expand Down
Loading