Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup hmr.json, remove old .R/.py/.jl files #11

Merged
merged 7 commits into from
Jan 28, 2021
Merged

Cleanup hmr.json, remove old .R/.py/.jl files #11

merged 7 commits into from
Jan 28, 2021

Conversation

xhluca
Copy link

@xhluca xhluca commented Jan 28, 2021

About

Description of changes

Pre-Merge checklist

  • The project was correctly built with npm run build.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash core contributor.

Reference Issues

Closes #[issue number]

Other comments

@xhluca xhluca changed the title Cleanup and regenerate Cleanup hmr.json, remove old .R/.py/.jl files Jan 28, 2021
jourdain
jourdain approved these changes Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@jourdain jourdain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xhluca xhluca merged commit aaf1bea into master Jan 28, 2021
@xhluca xhluca deleted the regenerate-package branch January 28, 2021 23:11
@xhluca xhluca mentioned this pull request Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jourdain jourdain jourdain approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

@Marc-Andre-Rivet Marc-Andre-Rivet Awaiting requested review from Marc-Andre-Rivet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhluca @jourdain