Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Issue 545 - Case-insensitive option for filters #609

Closed
wants to merge 13 commits into from
Closed

Issue 545 - Case-insensitive option for filters #609

wants to merge 13 commits into from

Conversation

dmt0
Copy link
Contributor

@dmt0 dmt0 commented Oct 1, 2019 •
edited
Loading

Closes #545
Implements case-insensitive filtering.

TODO:

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 1, 2019 20:32 Inactive
@dmt0 dmt0 force-pushed the case-insensitive-filters branch from 3eb59a3 to b15de46 Compare October 1, 2019 20:39
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 1, 2019 20:39 Inactive
@dmt0 dmt0 force-pushed the case-insensitive-filters branch from b15de46 to 7a12196 Compare October 1, 2019 20:41
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 1, 2019 20:42 Inactive
@dmt0 dmt0 force-pushed the case-insensitive-filters branch from 7a12196 to 1d46e06 Compare October 2, 2019 21:43
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 2, 2019 21:43 Inactive
@dmt0 dmt0 force-pushed the case-insensitive-filters branch from 1d46e06 to 9fe1ffb Compare October 7, 2019 17:14
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 7, 2019 17:15 Inactive
dmt0
dmt0 commented Oct 7, 2019
View reviewed changes
src/dash-table/dash/DataTable.js
* string is represented in this `filter_query`
* property.
*/
filter_query: PropTypes.string,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it after filter_action, because it depends on it

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 7, 2019 18:59 Inactive
@dmt0
Copy link
Contributor Author

dmt0 commented Oct 7, 2019

Ha! fontawesome's case icon is only available in pro:
https://fontawesome.com/icons/font-case?style=solid

@dmt0 dmt0 force-pushed the case-insensitive-filters branch from 1732a03 to 5c9fa95 Compare October 8, 2019 15:38
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 8, 2019 15:38 Inactive
@dmt0 dmt0 force-pushed the case-insensitive-filters branch from 5c9fa95 to b09272f Compare October 8, 2019 15:58
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 8, 2019 15:58 Inactive
@dmt0 dmt0 force-pushed the case-insensitive-filters branch from b09272f to 2372f39 Compare October 9, 2019 00:25
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 9, 2019 00:25 Inactive
@dmt0
Copy link
Contributor Author

dmt0 commented Oct 9, 2019

UI looks like this at the moment:
Oct-08-2019 20-29-04

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 9, 2019 00:56 Inactive
dmt0
dmt0 commented Oct 9, 2019
View reviewed changes
src/dash-table/components/Filter/Column.tsx
className={'dash-filter--case ' + filterCaseClass}
onClick={setColumnCase}
value='Aa'
/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to make this an input type button, because there was no other way to make this thing have cursor: pointer, it would still be text from input below it. Setting z-index did nothing.

@dmt0 dmt0 force-pushed the case-insensitive-filters branch from 466b6e3 to 8fa2125 Compare October 9, 2019 17:31
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 9, 2019 17:31 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 9, 2019 21:55 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 9, 2019 22:02 Inactive
@dmt0 dmt0 changed the title Case-insensitive option for filters WIP Issue 545 - Case-insensitive option for filters WIP Oct 9, 2019
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 9, 2019 23:08 Inactive
@dmt0 dmt0 force-pushed the case-insensitive-filters branch from 5a22eba to 901dc63 Compare October 9, 2019 23:11
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 9, 2019 23:11 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 9, 2019 23:20 Inactive
@dmt0 dmt0 force-pushed the case-insensitive-filters branch from 3257b22 to a24028b Compare October 10, 2019 20:38
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-609 October 10, 2019 20:38 Inactive
@dmt0 dmt0 changed the title Issue 545 - Case-insensitive option for filters WIP Issue 545 - Case-insensitive option for filters Oct 11, 2019
@dmt0
Copy link
Contributor Author

dmt0 commented Oct 11, 2019 •
edited
Loading

Ready for review.
The only issues I'm aware of is that clicking the button in the global filter doesn't refresh results, and the server test that fails - I need to set up the environment to run it locally and figure it out.

@dmt0 dmt0 self-assigned this Oct 11, 2019
@fheilz
Copy link

fheilz commented May 20, 2020 •
edited
Loading

Any update on the status of this? The case sensitive filter is somewhat annoying.

@Marc-Andre-Rivet Marc-Andre-Rivet added this to the OSS milestone Aug 28, 2020
This was referenced Apr 26, 2021
Closed
Merged
@wbrgss
Copy link
Contributor

wbrgss commented May 10, 2021 •
edited
Loading

Superseded by #893

@wbrgss wbrgss closed this May 10, 2021
@wbrgss wbrgss deleted the case-insensitive-filters branch May 10, 2021 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

@Marc-Andre-Rivet Marc-Andre-Rivet Awaiting requested review from Marc-Andre-Rivet

Assignees

@dmt0 dmt0

Labels
feature size: 1.5
Projects
None yet
Milestone
OSS
Development

Successfully merging this pull request may close these issues.

case insensitive filtering
5 participants
@dmt0 @fheilz @wbrgss @chriddyp @Marc-Andre-Rivet