-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for extra traces #40
Conversation
Thanks! The checklist above mentions that you added an example showing a contour but I could not find it, did you maybe forget to add it? |
Regarding the name, I like both |
Yes I did :)
Let's just stick with |
examples/threshold_contour.py
Outdated
{ | ||
"type": "scatter", | ||
"mode": "lines", | ||
"line": {"color": "cyan", "width": 3}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use different colors here for the different contours? It would make the example clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that each contour
was a linepiece, but I just learned they are each one closed contour. Cool!
Just a color-related nitpicking comment, but it looks good to go! |
extra_traces
prop, which is adcc.Store
that users can write a list of traces to.I considered using pattern matching, which would make it possible for the application to define multiple stores for additional traces. However, by simply proving a store via a property, we make the simpler cases easier, and the more complex cases can still define multiple stores and then add a callback to aggregate these into the
slicer.extra_traces
.Possible alternative names for
extra_traces
could be e.g.user_traces
, `more_traces.