This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Upgrade to React 16 #145
Merged
Merged
Upgrade to React 16 #145
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e1bfb4a
use react-16 renderer
bed2ba1
change react switch test
b4a1237
use dcc react-16 branch
4104916
update changelog
bd89c14
pr number
e04d650
circular dependency message
81f5941
lint
d3610bb
fix deleted default export...
4d9a9fb
remove react 15.4.2
0781448
Update index.js
Marc-Andre-Rivet 5b93f01
remove React 15.4.2 test
fb6d498
Merge branch 'react-16' of github.com:plotly/dash-renderer into react-16
c396cf6
default react version
3e5bb3b
Update CHANGELOG.md
Marc-Andre-Rivet 3f3a008
remove 15.4.2 code
726819d
Merge branch 'react-16' of github.com:plotly/dash-renderer into react-16
968d1f4
Merge branch 'master' into react-16
Marc-Andre-Rivet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,7 @@ jobs: | |
name: Install dependencies (dash) | ||
command: | | ||
git clone [email protected]:plotly/dash.git | ||
git clone [email protected]:plotly/dash-core-components.git | ||
git clone -b react-16 [email protected]:plotly/dash-core-components.git | ||
git clone [email protected]:plotly/dash-html-components.git | ||
git clone [email protected]:plotly/dash-table.git | ||
. venv/bin/activate | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,27 +12,17 @@ | |
from .version import __version__ | ||
__file__ | ||
|
||
_DEFAULT_REACT_VERSION = '15.4.2' | ||
_REACT_VERSION_TYPES = {'15.4.2', '16.2.0'} | ||
_DEFAULT_REACT_VERSION = '16.8.6' | ||
_REACT_VERSION_TYPES = {'16.8.6'} | ||
_REACT_VERSION_TO_URLS = { | ||
'15.4.2': { | ||
'16.8.6': { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fwiw, no need to update the manifest as it wildcards react and react-dom versions |
||
'external_url': [ | ||
'https://unpkg.com/react@15.4.2/dist/react.min.js', | ||
'https://unpkg.com/react-dom@15.4.2/dist/react-dom.min.js' | ||
'https://unpkg.com/react@16.8.6/umd/react.production.min.js', | ||
'https://unpkg.com/react-dom@16.8.6/umd/react-dom.production.min.js' | ||
], | ||
'relative_package_path': [ | ||
'[email protected]', | ||
'[email protected]' | ||
], | ||
}, | ||
'16.2.0': { | ||
'external_url': [ | ||
'https://unpkg.com/[email protected]/umd/react.production.min.js', | ||
'https://unpkg.com/[email protected]/umd/react-dom.production.min.js' | ||
], | ||
'relative_package_path': [ | ||
'[email protected]', | ||
'[email protected]' | ||
'[email protected]', | ||
'[email protected]' | ||
], | ||
} | ||
} | ||
|
@@ -46,9 +36,6 @@ def _set_react_version(react_version): | |
``` | ||
import dash_renderer | ||
|
||
# Set the react version before setting up the Dash application | ||
dash_renderer._set_react_version('16.2.0') | ||
|
||
app = dash.Dash(...) | ||
``` | ||
|
||
|
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be removed after master merge