This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
proptypes - don't let valid values break validation #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Thanks @chriddyp - nice catch. 💃
I notice oneOfType doesn't get propagated to the Python docstrings - so these just look like booleans now from the python side. Probably better than string as boolean supports both states, and also probably not worth addressing right now since dash-component-system will fix this
https://github.com/plotly/dash-component-system/blob/a95fee96f0bb6804b5f110a561d18aed0010ec85/dash_component_system/_component.py#L97-L106
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently users may be providing
TrueorFalsefor boolean properties or numbers for numeric properties. This is valid. With our previous propTypes, these would fail under validation as they are notstring.This PR enables those boolean & numeric properties.
There is a lot more we could do here for deeper validation (e.g. incorporate https://github.com/iandevlin/html-attributes/blob/master/enumerated-attributes.json) however I’d like to keep this PR focused on making sure that existing user’s code doesn’t break (even if it might not be technically valid under the HTML5 spec).