This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Fix number inputs for IE11 #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shammamah-zz
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
shammamah-zz
force-pushed
the
ie11-numeric-input
branch
from
59339ce to
06ab12e
Compare
shammamah-zz
force-pushed
the
ie11-numeric-input
branch
from
f95f74e to
096f013
Compare
src/components/Input.react.js
Outdated
| @@ -89,6 +92,11 @@ export default class Input extends PureComponent { | |||
| ); | |||
| } | |||
|
|
|||
| getValueAsNumber(value) { | |||
| const numericValue = convert(value); | |||
| return numericValue % 1 === 0 ? Math.floor(numericValue) : numericValue; | |||
There was a problem hiding this comment.
@shammamah Can you explain the reasoning for this line? If n % 1 === 0 isn't it already an integer?
There was a problem hiding this comment.
I wasn't sure if it would automatically convert to int vs. remaining as a float. Fixed in 24b3b9d.
src/components/Input.react.js
Outdated
| @@ -93,8 +93,7 @@ export default class Input extends PureComponent { | |||
| } | |||
|
|
|||
| getValueAsNumber(value) { | |||
| const numericValue = convert(value); | |||
| return numericValue % 1 === 0 ? Math.floor(numericValue) : numericValue; | |||
| return convert(value); | |||
There was a problem hiding this comment.
At this point why not just call convert directly?
There was a problem hiding this comment.
Fixed in 21281de!
Co-Authored-By: Marc-André Rivet <[email protected]>
JHSaunders
pushed a commit
to JHSaunders/dash-core-components
that referenced
this pull request
Mar 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #627.
About
The core of the issue was that
valueAsNumberwas always returningNaNeven if the input value was a number, which is a known issue with IE: https://caniuse.com/#feat=input-number