This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Issue 691 - Update plotlyjs #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Andre-Rivet
commented
Nov 4, 2019
| amnesiaed = dash_dcc.select_date_single( | ||
| "dps-none", day="1", outside_month=True | ||
| ) | ||
| amnesiaed = dash_dcc.select_date_single("dps-none", day="11") |
There was a problem hiding this comment.
Interesting month rollover bug in this test. November 2019 ends on a Saturday, there is no 1st day of next month in this calendar! This is the only instance where we are checking for "out-of-month" days in dcc tests. Out-of-month is not important here as we are really just testing persistence.
There was a problem hiding this comment.
Funny enough, https://github.com/plotly/dash-core-components/pull/692/commits was not affected even with the last commit happening in November b/c the test does -timedelta(days=1)
Marc-Andre-Rivet
requested review from
alexcjohnson and
byronz
as code owners
Marc-Andre-Rivet
commented
Nov 4, 2019
Co-Authored-By: alexcjohnson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #691