This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Issue434 - Clear date in DatePickerSingle and DatePickerRange #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 11, 2019 13:03
- basic unit tests
dash_core_components/metadata.json
Outdated
| @@ -2789,6 +2789,9 @@ | |||
| }, | |||
| { | |||
| "name": "string" | |||
| }, | |||
| { | |||
| "name": "bool" | |||
There was a problem hiding this comment.
In some previous commit the metadata was not updated correctly.
| @@ -22,6 +22,8 @@ import Tab from './components/Tab.react'; | |||
| import Store from './components/Store.react'; | |||
| import LogoutButton from './components/LogoutButton.react'; | |||
|
|
|||
| import './components/css/[email protected]'; | |||
There was a problem hiding this comment.
Moving this style dependency to the top level -- jest is not able to handle css files correctly atm
| case 'Undefined': | ||
| return; | ||
| case 'Null': | ||
| dest[key] = null; |
There was a problem hiding this comment.
Common logic between Single and Range + the new Null case
| expect(dps.props().start_date).toEqual(props.start_date); | ||
| expect(dps.state().start_date).not.toEqual(null); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Basic tests for range: passing null sets null in the state, otherwise it sets a value (do not care about the exact value atm, just differentiating the 2 cases)
| expect(dps.props()).toBeDefined(); | ||
| expect(dps.props().date).toEqual(props.date); | ||
| expect(dps.state().date).not.toEqual(null); | ||
| }); |
There was a problem hiding this comment.
Basic tests for single: passing null sets null in the state, otherwise it sets a value (do not care about the exact value atm, just differentiating the 2 cases)
alexcjohnson
approved these changes
Jan 22, 2019
added 2 commits
January 23, 2019 10:16
…-clear-date # Conflicts: # CHANGELOG.md # dash_core_components/dash_core_components.dev.js # dash_core_components/dash_core_components.dev.js.map # dash_core_components/dash_core_components.min.js # dash_core_components/dash_core_components.min.js.map
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434
Currently, DatePickerSingle and DatePickerRange do not process
nulldates correctly.Handle the null case by assigning the value as-is to the underlying react-dates component instead of wrapping it with moment.