-
-
Notifications
You must be signed in to change notification settings - Fork 144
Move PropTypes from React package to prop-types #160
Conversation
src/components/Upload.react.js
Outdated
@@ -1,4 +1,5 @@ | |||
import React, {Component, PropTypes} from 'react'; | |||
import PropTypes from 'prop-types'; | |||
import React, { Component } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nit-picky things. I have the personal convention of using {Component}
rather than { Component }
src/components/Upload.react.js
Outdated
@@ -252,4 +253,4 @@ Upload.defaultProps = { | |||
borderColor: '#c66', | |||
backgroundColor: '#eee' | |||
} | |||
}; | |||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, my editor will automatically add new lines to the ends of files whereas it looks like yours removes them. Could we add these newlines back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise the next time I make a PR, it'll have these superfluous diffs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind if I add a .editorconfig with a newline at the end of all files then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was the codemod that made all the style changes at the end of files.
Looks good to me here too. Once we change |
- Add newlines at end of file. - Add a .editorconfig for newlines at end of file.
@chriddyp fixed the style mismatches. I added a |
|
Description
This moves the
PropTypes
import fromreact
toprop-types
.Example:
is now
This will allow
dash-core-components
to support React 16+ by patching in different versions to thedash-renderer
by the Dash developer (for now).For example, in the application definition file:
Changes
package-lock.json