Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Fixed some warnings #106

Merged
merged 6 commits into from
Nov 2, 2017
Merged

Fixed some warnings #106

merged 6 commits into from
Nov 2, 2017

Conversation

Akronix
Copy link
Contributor

@Akronix Akronix commented Oct 31, 2017

Looking the browser console I got these warnings:

Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of `RadioItems`. See https://fb.me/react-warning-keys for more information.
    in label (created by RadioItems)
    in RadioItems
Warning: Failed prop type: Invalid prop `options` of type `array` supplied to `Checklist`, expected `object`.
    in Checklist (created by Controller)
    in Controller

This fixes them.

@Akronix Akronix changed the title Fixed propType for options and added key in map for RadioItems component Fixed some warnings Oct 31, 2017
@Akronix
Copy link
Contributor Author

Akronix commented Oct 31, 2017

I've located and resolved several more warnings I've found when running the demo.

@chriddyp
Copy link
Member

chriddyp commented Nov 2, 2017

This is great, thank you @Akronix !

@chriddyp chriddyp merged commit 5da557a into plotly:master Nov 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants