-
-
Notifications
You must be signed in to change notification settings - Fork 144
Can't put null values in store array? #422
Comments
Two different bugs.
|
What does this mean? That if my store is |
No it shouldn't break, just not update. |
That worked when I tried, maybe it was just the null check that was missing. I'll still add a test for that use case. |
The tests for the store data types changes will need to assert that changes from a combination of the different types will update the output. >>> pprint.pprint(list(itertools.combinations(['str', 'number', 'dict', 'list', 'None'], 2)))
[('str', 'number'),
('str', 'dict'),
('str', 'list'),
('str', 'None'),
('number', 'dict'),
('number', 'list'),
('number', 'None'),
('dict', 'list'),
('dict', 'None'),
('list', 'None')] |
You have to be a bit creative to find breaking cases, but a check that the type hasn't changed will fix them all v1='abc'
v2={0: 'a', 1: 'b', 2: 'c', length: 3}
v3=['a', 'b', 'c']
dataCheck(v2, v1)
dataCheck(v3, v1)
dataCheck(v2, v3)
dataCheck(v3, v2) While you're at it, would you mind changing the name |
Also we're not checking for removing keys from an object! |
It's a check to know if the data need refreshing for the |
Yes, I know what it is, but I didn't find that out from its name or (nonexistent) docstring, I had to read through the code and infer its intent. We can do better than that. What it does is a deep equality check, where a return value |
Not sure what is happening with the Store here (is this a bug or a limitation?)
This app seems to work since the array will be printed correctly in the
hello
callback, suggesting that everything worked out (np.array was serialized to a JSON array withnull
instead ofnp.nan
, this made it to the redux store, then thehello
callback was triggered and thenull
value was converted to aNone
.But this strange error is thrown, no idea why

The text was updated successfully, but these errors were encountered: