WIP review checklist #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
force-pushed
the
review-checklist
branch
2 times, most recently
from
e8e3d09 to
851d90a
Compare
wilzbach
reviewed
Oct 11, 2018
| @@ -1,17 +1,14 @@ | |||
| /* eslint no-magic-numbers: 0 */ | |||
| import React, {Component} from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import * as R from 'ramda'; | |||
There was a problem hiding this comment.
Probably a good idea to remove these dependencies (or at least ramda) from the dependencies if they are never used.
VeraZab
force-pushed
the
review-checklist
branch
from
851d90a to
f2115d4
Compare
T4rk1n
added a commit
that referenced
this pull request
Oct 15, 2018
|
I implemented most changes (added checklist, removed unused, added info to readme) in this PR in the cookiecutter that is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses: #plotly/dash#420