React 16.13 (#494)

plotly · Mar 10, 2020 · c286d79 · c286d79
1 parent 28d37e0
commit c286d79
Show file tree

Hide file tree

Showing 10 changed files with 38 additions and 22 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -59,7 +59,7 @@ jobs:
             - run: echo $PYVERSION > ver.txt
 
             - restore_cache:
-                key: deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ checksum "ver.txt" }}
+                key: deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ checksum "ver.txt" }}-{{ checksum ".circleci/config.yml" }}
 
             - run:
                 name: Create virtualenv
@@ -71,13 +71,20 @@ jobs:
                 command: |
                     . venv/bin/activate
                     pip install --progress-bar off -r tests/requirements.txt --quiet
-                    pip install --progress-bar off dash[testing]
 
             - save_cache:
-                key: deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ checksum "ver.txt" }}
+                key: deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ checksum "ver.txt" }}-{{ checksum ".circleci/config.yml" }}
                 paths:
                     - venv
 
+            - run:
+                name: Install Dash
+                command: |
+                    . venv/bin/activate
+                    git clone --depth 1 https://github.com/plotly/dash.git dash-main
+                    cd dash-main && pip install -e .[dev,testing]
+                    cd dash-renderer && npm run build && pip install -e . && cd ../..
+
             - run:
                 name: Run pylint
                 command: |

diff --git a/.pylintrc b/.pylintrc
@@ -151,6 +151,8 @@ disable=print-statement,
         too-many-lines,
         too-many-instance-attributes,
         too-few-public-methods,
+        unsubscriptable-object,
+        unsupported-assignment-operation,
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## [Unreleased]
 ### Changed
 * [#489](https://github.com/plotly/dash-bio/pull/489) Renamed async modules with hyphen `-` instead of tilde `~`
+- [#494](https://github.com/plotly/dash-bio/pull/494) Update from React 16.8.6 to 16.13.0
 
 ## [0.4.7] - 2020-02-21
 ### Added

diff --git a/dash_bio/async-needle.js b/dash_bio/async-needle.js
diff --git a/dash_bio/bundle.js b/dash_bio/bundle.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -39,9 +39,9 @@
     "molecule-3d-for-react": "git://github.com/plotly/molecule-3d-for-react.git",
     "plotly.js": "^1.52.2",
     "ramda": "^0.26.0",
-    "react": "16.8.6",
+    "react": "16.13.0",
     "react-alignment-viewer": "^0.5.5",
-    "react-dom": "16.8.6",
+    "react-dom": "16.13.0",
     "react-oncoprint": "^1.2.3",
     "react-plotly.js": "^2.4.0",
     "react-sequence-viewer": "git://github.com/plotly/react-sequence-viewer.git",

diff --git a/requirements.txt b/requirements.txt
@@ -2,7 +2,6 @@
 # pip install -r requirements.txt
 
 cython>=0.19
-dash>=1.6.1
 dash-bio-utils==0.0.4
 dash-daq==0.2.2
 gunicorn==19.9.0

diff --git a/src/lib/fragments/NeedlePlot.react.js b/src/lib/fragments/NeedlePlot.react.js
@@ -107,7 +107,7 @@ export default class NeedlePlot extends Component {
         this.handleChange = this.handleChange.bind(this);
     }
 
-    componentWillMount() {
+    UNSAFE_componentWillMount() {
         // For default argument of taken from defaultProps deeply nested
         this.props = mergeDeepRight(NeedlePlot.defaultProps, this.props);
     }

diff --git a/tests/requirements.txt b/tests/requirements.txt
@@ -1,7 +1,4 @@
 -r ../requirements.txt
 
 # Additional packages needed to run the tests.
-chromedriver-binary==2.45.0
-flake8==3.6.0
 ipdb==0.11
-pylint==2.3.0