Upgraded nextjs deps and configuration #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
|
@pnicolli I am one of the late "ESM" all the things. How about declare the nextjs app |
|
@sneridagh I didn't dig deep into that world yet. What would be the change you are proposing? What I did here is basically to create an empty nextjs project with the suggested tooling in the nextjs docs and copy the config over here 😛 |
|
@pnicolli yeah, basically then you don't have to do the |
|
@sneridagh I gave it some thought and I think I merged main and fixed a couple eslint warnings, the PR about providers would also benefit from this PR imho. |
sneridagh
approved these changes
Oct 15, 2024
| @@ -4,6 +4,7 @@ | |||
| /node_modules | |||
| /.pnp | |||
| .pnp.js | |||
| .yarn/install-state.gz | |||
There was a problem hiding this comment.
It's in the latest create-next-app basic template 😅
sneridagh
added a commit
that referenced
this pull request
Oct 17, 2024
* betterproviders: Fix linting Changelog Latest touches Better branding here Apply suggestions from code review Return whole context instead of only useLocation Adjust the path to perform a proper `git diff` between the cached and… (#6410) Test whether commenting out the `ignore` command has any affect on the Netlify build. Better admonitions format for experimental notices. support depth in getNavigationQuery (#6400) Update caniuse Oct24 (#6408) Upgraded nextjs deps and configuration (#6388)
sneridagh
added a commit
that referenced
this pull request
Oct 18, 2024
* main: Release generate-volto 9.0.0-alpha.19 Release @plone/providers 1.0.0-alpha.3 Release @plone/components 2.0.0-alpha.16 Release @plone/client 1.0.0-alpha.19 Release @plone/types 1.0.0-alpha.21 Some types improvements/fixes (#6412) [providers] Improve and group providers (#6069) Adjust the path to perform a proper `git diff` between the cached and… (#6410) Test whether commenting out the `ignore` command has any affect on the Netlify build. support depth in getNavigationQuery (#6400) Update caniuse Oct24 (#6408) Upgraded nextjs deps and configuration (#6388) Update `typescript` and `vitest` everywhere (#6407) Remove all traces of Jest 24 in core (#6406) Release @plone/components 2.0.0-alpha.15 [components] Fix Select component logic to support `items` use case (#6405) Fix clean make command (#6403)
sneridagh
pushed a commit
that referenced
this pull request
Oct 18, 2024
sneridagh
added a commit
that referenced
this pull request
Oct 18, 2024
* main: (37 commits) Release generate-volto 9.0.0-alpha.19 Release @plone/providers 1.0.0-alpha.3 Release @plone/components 2.0.0-alpha.16 Release @plone/client 1.0.0-alpha.19 Release @plone/types 1.0.0-alpha.21 Some types improvements/fixes (#6412) [providers] Improve and group providers (#6069) Adjust the path to perform a proper `git diff` between the cached and… (#6410) Test whether commenting out the `ignore` command has any affect on the Netlify build. support depth in getNavigationQuery (#6400) Update caniuse Oct24 (#6408) Upgraded nextjs deps and configuration (#6388) Update `typescript` and `vitest` everywhere (#6407) Remove all traces of Jest 24 in core (#6406) Release @plone/components 2.0.0-alpha.15 [components] Fix Select component logic to support `items` use case (#6405) Fix clean make command (#6403) Release 18.0.0-alpha.46 Release @plone/components 2.0.0-alpha.14 Add missing export for new components (#6391) ...
sneridagh
added a commit
that referenced
this pull request
Oct 22, 2024
* main: (23 commits) Aliases control panel: Improve layout and add CSV upload (#6421) Fix site setup access at toolbar by using @actions endpoint. (#6413) Remove last CI tests still in 18 (#6418) Node 22 as LTS, main and recommended Volto version (#6371) Refactor Aliases control panel and support new filters (#6414) Remove the Plone app from apps folder (#6415) Release generate-volto 9.0.0-alpha.19 Release @plone/providers 1.0.0-alpha.3 Release @plone/components 2.0.0-alpha.16 Release @plone/client 1.0.0-alpha.19 Release @plone/types 1.0.0-alpha.21 Some types improvements/fixes (#6412) [providers] Improve and group providers (#6069) Adjust the path to perform a proper `git diff` between the cached and… (#6410) Test whether commenting out the `ignore` command has any affect on the Netlify build. support depth in getNavigationQuery (#6400) Update caniuse Oct24 (#6408) Upgraded nextjs deps and configuration (#6388) Update `typescript` and `vitest` everywhere (#6407) Remove all traces of Jest 24 in core (#6406) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.