Babel upgrade v7 #584
Babel upgrade v7 #584
Conversation
| "prettier": "1.14.3", | ||
| "promise-file-reader": "1.0.2", | ||
| "query-string": "6.1.0", | ||
| "raven": "2.6.4", | ||
| "raven-js": "3.27.0", | ||
| "razzle": "2.4.0", | ||
| "razzle": "3.0.0-alpha.0", |
There was a problem hiding this comment.
@nileshgulia1 we might want to wait for a final version of Razzle here. I guess this upgrade is necessary for Babel 7? Or does Razzle 2.4 work with Babel 7 as well?
There was a problem hiding this comment.
@tisto We are having babel 7 presets with razzle v3 . But since we're using razzle's presets for babel, for v7 we have to use razzle v3, otherwise we may opt out using razzle's babel configs.
| > | ||
| Contributer | ||
| </th> | ||
| /> |
There was a problem hiding this comment.
@nileshgulia1 it seems there are a few unrelated changes in the PR (tests, CSS, SVG, Icons). Or am I missing something here?
There was a problem hiding this comment.
@tisto Yes there are some updated snapshots, and few svg's for default semantic theme, which added when working on less v3.9.0 and semantic-ui-less upgrades. Although some SVG's and icons from the default semantic theme can be removed.
Pull Request Test Coverage Report for Build 2757
💛 - Coveralls |
|
@nileshgulia1 Crap, look at #585 ... I already worked on that this week :( I thought that you only were taking care of the Babel 7 testing... try to maintain your PRs as atomic as possible, so only one thing is accomplished. Then reverting or backtracking changes is also easier. You can tell by taking a look into your changelog entry... currently doesn't mention the update (which could be huge) and it's mixed with another biggie, which is Babel 7 upgrade. I even already made a review on the semantic UI and theme upgrades and I spotted several caveats that I had to fix on my PR. I even made a quick review on the whole resulting live site and it's fine, so I would better use my PR and merge it already. @robgietema already reviewed it today. That doesn't mean that you made a great work, in fact, it's great that you already looked into that and know the innards of semantic and how it works. Keep up the good work! @tisto regarding the upgrade, I am a bit reluctant if it's required to rely on a super recent Razzle alpha version, I won't merge it (yet) :( @nileshgulia1 might be a way to upgrade without upgrade razzle? |
@sneridagh Yes, that's a huge mess, I will take care about that from now on.
I guess we have to refrain from using |
|
@sneridagh would close this ticket? |
|
@nileshgulia1 no, not yet. Let's wait for Timo to weigh in. Please, remove/revert all the things related with the less and semantic upgrade as well (package.json, default theme etc) |
nileshgulia1
force-pushed
the
babel-upgrade
branch
from
aed45a8 to
b51f9ba
Compare
|
If we go with styleguidist instead of docz I don't need the babel 7 upgrade urgently. Would be nice to have though. Maybe we should keep this PR open until we merged all the stuff that it contains. |
|
The builds will pass after we get latest |
|
Superseeded by #711 |
|
@nileshgulia1 thanks a lot!!, it saved me a lot of time, just pushed #711 |
Addresses: #580