Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #1001 - Make tests more generic #1002

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Conversation

avoinea
Copy link
Member

@avoinea avoinea commented Oct 2, 2020

@mister-roboto
Copy link

@avoinea thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@avoinea
Copy link
Member Author

avoinea commented Oct 2, 2020

@jenkins-plone-org please run jobs

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 94.472% when pulling 4bca687 on sync-schema-on-zeo-clients into e8b3e9c on master.

Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and needed to solve the caching invalidation issue for ttw schemas.

@jensens jensens merged commit 68a00da into master Oct 5, 2020
@tisto tisto deleted the sync-schema-on-zeo-clients branch October 5, 2020 08:16
@tisto tisto restored the sync-schema-on-zeo-clients branch October 5, 2020 08:16
@tisto tisto deleted the sync-schema-on-zeo-clients branch October 5, 2020 08:16
tisto pushed a commit that referenced this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants