Added security checks for str.format. Part of PloneHotfix20170117. [5.1] #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauritsvanrees
added
01 type: bug
23 status: testing
24 status: ready
32 needs: review
and removed
23 status: testing
labels
thet
reviewed
Feb 7, 2017
There was a problem hiding this comment.
@mauritsvanrees - since I'm not totally sure about the intentions of your PR I ask you to correct the wrong import in mixins.py.
Same as in this PR: #1912 (review)
| @@ -68,7 +69,7 @@ def __call__(self): | |||
| less_vars_params[name] = value | |||
|
|
|||
| for name, value in registry.items(): | |||
| t = value.format(**less_vars_params) | |||
| t = SafeFormatter(value).safe_format(**less_vars_params) | |||
There was a problem hiding this comment.
@mauritsvanrees you have imported safe_format but using SafeFormatter. This leads to an error mentioned here: #1938 (comment)
| @@ -117,7 +118,7 @@ def __call__(self): | |||
| less_vars_params[name] = value | |||
|
|
|||
| for name, value in registry.items(): | |||
| t = value.format(**less_vars_params) | |||
| t = SafeFormatter(value).safe_format(**less_vars_params) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #1912 for 5.1.