Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch - message dst fatal error #199

Merged
merged 2 commits into from
Dec 17, 2020
Merged

catch - message dst fatal error #199

merged 2 commits into from
Dec 17, 2020

Conversation

huzaif-plivo
Copy link
Contributor

No description provided.

narayana-plivo
narayana-plivo approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@narayana-plivo narayana-plivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its good to define the dst param type array in function param. Please check with Nixon once on this change. It wont breaking existing structure like if you send array of dst number

@nixonsam nixonsam merged commit 25e6576 into master Dec 17, 2020
@nixonsam nixonsam deleted the SUP-1903 branch December 17, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixonsam nixonsam nixonsam approved these changes

@narayana-plivo narayana-plivo narayana-plivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huzaif-plivo @nixonsam @narayana-plivo