Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieve_application response #197

Merged
merged 2 commits into from
Dec 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Change Log

## [v4.16.0](https://github.com/plivo/plivo-php/releases/tag/v4.16.0) - 2020-12-08
- Fix retrieve_application API response.

## [v4.15.1](https://github.com/plivo/plivo-php/releases/tag/v4.15.1) - 2020-11-17
- Fix resource not found exception when making sequential requests.

Expand Down
8 changes: 7 additions & 1 deletion src/Plivo/Resources/Application/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@
* endpoint attached to the application, Plivo will send a request to the
* answer_url with the attributes of the call. We expect a valid Plivo XML to
* be returned as a response to the request Plivo makes.
* @property string $apiId
* @property string $appId
* @property string $appName A friendly name for your Plivo application.
* @property string $applicationType represents the type of application.
* @property string $defaultApp Default app
* @property boolean $defaultEndpointApp Default to an Endpoint
* @property boolean $enabled Set to true if the application is enabled.
* @property string $fallbackAnswerUrl Plivo will request this URL with the
* same parameters sent to the answer_url if the answer_url returns a non 200
Expand Down Expand Up @@ -65,9 +68,12 @@ public function __construct(BaseClient $client, $response, $authId)
$this->properties = [
'answerMethod' => $response['answer_method'],
'answerUrl' => $response['answer_url'],
'apiId' => $response['api_id'],
'appId' => $response['app_id'],
'appName' => $response['app_name'],
'applicationType' => $response['application_type'],
'defaultApp' => $response['default_app'],
'defaultEndpointApp' => $response['default_endpoint_app'],
'enabled' => $response['enabled'],
'fallbackAnswerUrl' => $response['fallback_answer_url'],
'fallbackMethod' => $response['fallback_method'],
Expand All @@ -79,7 +85,7 @@ public function __construct(BaseClient $client, $response, $authId)
'resourceUri' => $response['resource_uri'],
'sipUri' => $response['sip_uri'],
'subAccount' => $response['sub_account'],
'logIncomingMessages' => $response['log_incoming_messages']
'logIncomingMessages' => $response['log_incoming_message']
];

$this->pathParams = [
Expand Down
4 changes: 2 additions & 2 deletions src/Plivo/Version.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ class Version
/**
* @const int PHP helper library minor version number
*/
const MINOR = 15;
const MINOR = 16;
/**
* @const int PHP helper library patch number
*/
const PATCH = 1;
const PATCH = 0;
/**
* @return string
*/
Expand Down